Re: [PATCH 3/7] rbd: pass null version pointer in add_snap()

[Josh Durgin <josh.durgin@inktank.com>]

On 07/26/2012 12:08 PM, Alex Elder wrote:
> rbd_header_add_snap() passes the address of a version variable to
> rbd_req_sync_exec(), but it ignores the result.  Just pass a null
> pointer instead.
>
> Signed-off-by: Alex Elder <elder@inktank.com>

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

> ---
>   drivers/block/rbd.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 4d8b52c..eacf255 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -1664,7 +1664,6 @@ static int rbd_header_add_snap(struct rbd_device
> *rbd_dev,
>   	u64 new_snapid;
>   	int ret;
>   	void *data, *p, *e;
> -	u64 ver;
>   	struct ceph_mon_client *monc;
>
>   	/* we should create a snapshot only if we're pointing at the head */
> @@ -1689,7 +1688,7 @@ static int rbd_header_add_snap(struct rbd_device
> *rbd_dev,
>
>   	ret = rbd_req_sync_exec(rbd_dev, rbd_dev->header_name,
>   				"rbd", "snap_add",
> -				data, p - data, &ver);
> +				data, p - data, NULL);
>
>   	kfree(data);
>