From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: Andreas Jaeger <aj@suse.com>, Riku Voipio <riku.voipio@iki.fi>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.
Date: Mon, 30 Jul 2012 23:33:02 +0200 [thread overview]
Message-ID: <5016FD8E.8070201@suse.de> (raw)
In-Reply-To: <F8E60893-20FC-4653-B7DC-114AEDC3A3E0@suse.de>
Am 30.07.2012 23:30, schrieb Alexander Graf:
>
> On 30.07.2012, at 09:21, Andreas Jaeger wrote:
>
>>
>> glibc 2.16 does not export the undocumented struct siginfo anymore.
>> qemu uses already in most cases siginfo_t, this patch fixes the last
>> three occurences.
>>
>> Signed-off-by: Andreas Jaeger <ajsuse.de>
>
> That email address doesn't look valid :).
>
> So I take it that the change is backwards compatible? Riku, Mike, Andreas, could we queue this for the respective stable branches when it gets it please?
Wasn't there already another patch doing the same thing a few weeks ago?
Andreas
>
>
> Alex
>
>> ---
>> linux-user/signal.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/linux-user/signal.c b/linux-user/signal.c
>> index 97f30d9..a859a45 100644
>> --- a/linux-user/signal.c
>> +++ b/linux-user/signal.c
>> @@ -3255,7 +3255,7 @@ struct target_signal_frame {
>> };
>>
>> struct rt_signal_frame {
>> - struct siginfo info;
>> + siginfo_t info;
>> struct ucontext uc;
>> uint32_t tramp[2];
>> };
>> @@ -3474,9 +3474,9 @@ struct target_signal_frame {
>> };
>>
>> struct rt_signal_frame {
>> - struct siginfo *pinfo;
>> + siginfo_t *pinfo;
>> void *puc;
>> - struct siginfo info;
>> + siginfo_t info;
>> struct ucontext uc;
>> uint8_t retcode[8]; /* Trampoline code. */
>> };
>> --
>> 1.7.10.4
>>
>>
>> --
>> Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
>> GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
>>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-30 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 7:21 [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo Andreas Jaeger
2012-07-30 21:30 ` Alexander Graf
2012-07-30 21:33 ` Andreas Färber [this message]
2012-07-30 21:38 ` Peter Maydell
2012-07-30 21:41 ` Alexander Graf
2012-07-31 7:07 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5016FD8E.8070201@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aj@suse.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.