From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: "Trond.Myklebust@netapp.com" <Trond.Myklebust@netapp.com>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"devel@openvz.org" <devel@openvz.org>
Subject: SUNRPC lients: Pipefs mount races
Date: Tue, 31 Jul 2012 15:02:30 +0400 [thread overview]
Message-ID: <5017BB46.6080203@parallels.com> (raw)
Hello, Trond.
I found one more race in SUNRPC PipeFS mount notification and clients creation.
Now the problem is in SUNRPC clients.
Races are shown below:
CPU#0 CPU#1
------------------------------------ --------------------------------
nfs_create_rpc_client
rpc_create
rpc_new_client
rpc_setup_pipedir (no sb)
rpc_mount
notifier_call(SUNRPC - clnt.c)
rpc_register_client
nfs_idmap_new
nfs_mark_client_ready(NFS_CS_READY)
notifier_call(NFS - idmap.c)
__rpc_pipefs_event
BUG_ON(cl_dentry == NULL)
How would you prefer to fix this?
Looks like we could either try to add SUNRPC client to the list before PipeFS
dentry creation or create the dentry for SUNRPC client from NFS code in
__rpc_pipefs_event() instead of BUG_ON.
--
Best regards,
Stanislav Kinsbursky
reply other threads:[~2012-07-31 11:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017BB46.6080203@parallels.com \
--to=skinsbursky@parallels.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=devel@openvz.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.