From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBoN-0006Yh-MR for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:44:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwBoI-0006h3-05 for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:44:31 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:56700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBoH-0006gh-NL for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:44:25 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 31 Jul 2012 13:44:23 +0100 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6VCiLga3129472 for ; Tue, 31 Jul 2012 13:44:21 +0100 Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6VCiKoN027257 for ; Tue, 31 Jul 2012 06:44:20 -0600 Message-ID: <5017D324.4050008@de.ibm.com> Date: Tue, 31 Jul 2012 14:44:20 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1343293186-18372-1-git-send-email-borntraeger@de.ibm.com> <942124BF-C46B-4896-9758-B03E919D0E62@suse.de> In-Reply-To: <942124BF-C46B-4896-9758-B03E919D0E62@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Blue Swirl , Heinz Graalfs , qemu-devel , Jens Freimann , afaerber@suse.de On 30/07/12 16:05, Alexander Graf wrote: > > On 26.07.2012, at 10:59, Christian Borntraeger wrote: > >> This patch makes the sclp ascii default for S390. It requires a guest >> kernel that autodetects the console and which not blindly assumes >> that kvm means virtio console. >> (commit cd1834591fe9564720ac4b0193bf1c790fe89f0d >> KVM: s390: Perform early event mask processing during boot) >> Otherwise the guest admin has to explicitely add console=ttyS1 to the >> command line. > > Hrm. Could we make this the non-default for the time being with a simple -machine option to switch it to the default? When enough kernels are aware of the switch, we could then make it the default. No problem, we can defer that patch. It was merely a testing aid for those who want to test the sclp code. Later on maybe we can make that decision based on other thing.