From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBwh-0001RP-2Y for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:53:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwBwT-0001Fv-6a for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:53:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51662 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBwS-0001FM-W4 for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:52:53 -0400 Message-ID: <5017D51F.9090609@suse.de> Date: Tue, 31 Jul 2012 14:52:47 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1343293186-18372-1-git-send-email-borntraeger@de.ibm.com> <942124BF-C46B-4896-9758-B03E919D0E62@suse.de> <5017D324.4050008@de.ibm.com> In-Reply-To: <5017D324.4050008@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Blue Swirl , Heinz Graalfs , qemu-devel , Jens Freimann , afaerber@suse.de On 07/31/2012 02:44 PM, Christian Borntraeger wrote: > On 30/07/12 16:05, Alexander Graf wrote: >> On 26.07.2012, at 10:59, Christian Borntraeger wrote: >> >>> This patch makes the sclp ascii default for S390. It requires a guest >>> kernel that autodetects the console and which not blindly assumes >>> that kvm means virtio console. >>> (commit cd1834591fe9564720ac4b0193bf1c790fe89f0d >>> KVM: s390: Perform early event mask processing during boot) >>> Otherwise the guest admin has to explicitely add console=ttyS1 to the >>> command line. >> Hrm. Could we make this the non-default for the time being with a simple -machine option to switch it to the default? When enough kernels are aware of the switch, we could then make it the default. > No problem, we can defer that patch. It was merely a testing aid for those who want to test the > sclp code. Later on maybe we can make that decision based on other thing. Well, I'd like to have the logic around and easy to choose. Basically what I envision is that one day we do a flag day that introduces a compatibility machine type which only differs from the current one in that it sets said machine opt to "use ascii console as default". That way for the time being, people who want to play with it only need to do -machine ascii_console=on and everything else would happen automatically. It'd definitely make it easier for everyone involved. Alex