From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Any reason to use put_page in slub.c?
Date: Tue, 31 Jul 2012 18:09:49 +0400 [thread overview]
Message-ID: <5017E72D.2060303@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1207310906350.32295@router.home>
On 07/31/2012 06:09 PM, Christoph Lameter wrote:
> That is understood. Typically these object where page sized though and
> various assumptions (pretty dangerous ones as you are finding out) are
> made regarding object reuse. The fallback of SLUB for higher order allocs
> to the page allocator avoids these problems for higher order pages.
omg...
I am curious how slab handles this, since it doesn't seem to refcount in
the same way slub does?
Now, I am still left with the original problem:
__free_pages() here would be a superior solution, and the right thing to
do. Should we just convert it - and then fix whoever we find to be
abusing it (it doesn't mean anything, but I am running it on my systems
since then - 0 problems), or should I just create a hacky
put_accounted_page()?
I really, really dislike the later.
Anyone else would care to comment on this ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-31 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 12:19 Any reason to use put_page in slub.c? Glauber Costa
2012-07-27 15:55 ` Christoph Lameter
2012-07-30 7:53 ` Glauber Costa
2012-07-30 19:23 ` Christoph Lameter
2012-07-31 8:25 ` Glauber Costa
2012-07-31 14:09 ` Christoph Lameter
2012-07-31 14:09 ` Glauber Costa [this message]
2012-07-31 14:17 ` Christoph Lameter
2012-07-31 14:18 ` Glauber Costa
2012-07-31 14:31 ` Christoph Lameter
2012-07-31 14:52 ` James Bottomley
2012-08-01 12:42 ` Glauber Costa
2012-08-01 18:10 ` Christoph Lameter
2012-08-02 7:55 ` Glauber Costa
2012-08-02 8:07 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017E72D.2060303@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.