From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Date: Tue, 31 Jul 2012 15:25:07 +0100 Message-ID: <5017EAC3.3080504@linaro.org> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-3-git-send-email-lee.jones@linaro.org> <20120731134214.GK4468@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ey0-f179.google.com (mail-ey0-f179.google.com [209.85.215.179]) by alsa0.perex.cz (Postfix) with ESMTP id B3DCB26531A for ; Tue, 31 Jul 2012 16:25:07 +0200 (CEST) Received: by eaaa13 with SMTP id a13so1120149eaa.38 for ; Tue, 31 Jul 2012 07:25:09 -0700 (PDT) In-Reply-To: <20120731134214.GK4468@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMzEvMDcvMTIgMTQ6NDIsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gVHVlLCBKdWwgMzEsIDIw MTIgYXQgMDI6MzE6MjNQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+PiBJZiBhIGxpc3Qgb2Yg d2lkZ2V0cyBpcyBwcm92aWRlZCBhbmQgb25lIG9mIHRoZW0gZmFpbHMgdG8gYmUgYWRkZWQgYXMK Pj4gYSBjb250cm9sLCB0aGUgcHJlc2VudCBzZW1hbnRpY3MgZmFpbCBhbGwgc3Vic2VxdWVudCB3 aWRnZXRzLiBBIGJldHRlcgo+PiBzb2x1dGlvbiB3b3VsZCBiZSB0byBvbmx5IGZhaWwgdGhhdCB3 aWRnZXQsIGJ1dCBwdXJzdWUgaW4gYXR0ZW1wdGluZwo+PiB0byBhZGQgdGhlIHJlc3Qgb2YgdGhl IGxpc3QuCj4KPiBZb3UncmUgcG9zdGluZyB0aGlzICphZ2Fpbiogd2l0aG91dCBib3RoZXJpbmcg dG8gcmVzcG9uZCB0byBteSByZXZpZXcKPiBjb21tZW50cy4KCgpJIGRpZG4ndCBzZWUgYW55IGNv bW1lbnRzIG9uIHRoaXMuCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBMYW5kaW5n IFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNv Q3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlz dApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 31 Jul 2012 15:25:07 +0100 Subject: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too In-Reply-To: <20120731134214.GK4468@opensource.wolfsonmicro.com> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-3-git-send-email-lee.jones@linaro.org> <20120731134214.GK4468@opensource.wolfsonmicro.com> Message-ID: <5017EAC3.3080504@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31/07/12 14:42, Mark Brown wrote: > On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: >> If a list of widgets is provided and one of them fails to be added as >> a control, the present semantics fail all subsequent widgets. A better >> solution would be to only fail that widget, but pursue in attempting >> to add the rest of the list. > > You're posting this *again* without bothering to respond to my review > comments. I didn't see any comments on this. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298Ab2GaOZc (ORCPT ); Tue, 31 Jul 2012 10:25:32 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:54793 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618Ab2GaOZL (ORCPT ); Tue, 31 Jul 2012 10:25:11 -0400 Message-ID: <5017EAC3.3080504@linaro.org> Date: Tue, 31 Jul 2012 15:25:07 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-3-git-send-email-lee.jones@linaro.org> <20120731134214.GK4468@opensource.wolfsonmicro.com> In-Reply-To: <20120731134214.GK4468@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/12 14:42, Mark Brown wrote: > On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: >> If a list of widgets is provided and one of them fails to be added as >> a control, the present semantics fail all subsequent widgets. A better >> solution would be to only fail that widget, but pursue in attempting >> to add the rest of the list. > > You're posting this *again* without bothering to respond to my review > comments. I didn't see any comments on this. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog