From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 5/6] ARM: ux500: Enable HIGHMEM on all mop500 platforms Date: Tue, 31 Jul 2012 15:29:48 +0100 Message-ID: <5017EBDC.6010005@linaro.org> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-10-git-send-email-lee.jones@linaro.org> <20120731135614.GR6802@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ey0-f179.google.com (mail-ey0-f179.google.com [209.85.215.179]) by alsa0.perex.cz (Postfix) with ESMTP id 3D09D265E25 for ; Tue, 31 Jul 2012 16:29:48 +0200 (CEST) Received: by eaaa13 with SMTP id a13so1121781eaa.38 for ; Tue, 31 Jul 2012 07:29:50 -0700 (PDT) In-Reply-To: <20120731135614.GR6802@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Russell King - ARM Linux Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, olalilja@yahoo.se, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMzEvMDcvMTIgMTQ6NTYsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCB3cm90ZToKPiBPbiBU dWUsIEp1bCAzMSwgMjAxMiBhdCAwMjozMTozMFBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4+ IFRoZSBjdXJyZW50IGtlcm5lbCBjb21tYW5kbGluZSBmb3IgdXg1MDAgYmFzZWQgZGV2aWNlcyBp bmNsdWRlcwo+PiBoYXJkLWNvZGVkIGFsbG9jYXRpb25zIGZvciB0aGluZ3MgbGlrZSBtYWxpIGFu ZCBod21lbSwgd2hpY2gKPj4gYWN0dWFsbHkgcnVuIG92ZXIgbG93bWVtLiBIZXJlIHdlIGVuYWJs ZSBoaWdobWVtIGluIG9yZGVyIHRvCj4+IGF2b2lkIG1lbW9yeSBjb3JydXB0aW9uIGVycm9ycy4K Pgo+IEVyciB3aGF0PyAgaGlnaG1lbSBzaG91bGQgbWFrZSBubyBkaWZmZXJlbmNlIGlmIHRoaW5n cyBhcmUgYmVpbmcgZG9uZQo+IGNvcnJlY3RseS4KPgo+IEluIG90aGVyIHdvcmRzLCB5b3VyIHBh dGNoIGRlc2NyaXB0aW9uIGlzIHRvbyB2YWd1ZSB0byB1bmRlcnN0YW5kIHdoYXQKPiB0aGUgcHJv YmxlbSBpcyBhbmQgd2h5IHlvdSBoYXZlIHRvIGZvcmNlIGhpZ2htZW0gb24gLSBhbmQgbm90aGlu ZyBzaG91bGQKPiBfcmVxdWlyZV8gaGlnaG1lbS4KCkkgdGhpbmsgSSBtdXN0IGhhdmUgbWlzdW5k ZXJzdG9vZCBzb21lIGFkdmljZSB3aGljaCB3YXMgcmVjZW50bHkgZ2l2ZW4gCnRvIG1lLiBJJ2xs IGRyb3AgdGhlIHBhdGNoLgoKVGhhbmtzIGZvciByZXZpZXdpbmcuCgotLSAKTGVlIEpvbmVzCkxp bmFybyBTVC1Fcmljc3NvbiBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNv dXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0 dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0 cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 31 Jul 2012 15:29:48 +0100 Subject: [PATCH 5/6] ARM: ux500: Enable HIGHMEM on all mop500 platforms In-Reply-To: <20120731135614.GR6802@n2100.arm.linux.org.uk> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-10-git-send-email-lee.jones@linaro.org> <20120731135614.GR6802@n2100.arm.linux.org.uk> Message-ID: <5017EBDC.6010005@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31/07/12 14:56, Russell King - ARM Linux wrote: > On Tue, Jul 31, 2012 at 02:31:30PM +0100, Lee Jones wrote: >> The current kernel commandline for ux500 based devices includes >> hard-coded allocations for things like mali and hwmem, which >> actually run over lowmem. Here we enable highmem in order to >> avoid memory corruption errors. > > Err what? highmem should make no difference if things are being done > correctly. > > In other words, your patch description is too vague to understand what > the problem is and why you have to force highmem on - and nothing should > _require_ highmem. I think I must have misunderstood some advice which was recently given to me. I'll drop the patch. Thanks for reviewing. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522Ab2GaO3y (ORCPT ); Tue, 31 Jul 2012 10:29:54 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:37192 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754455Ab2GaO3v (ORCPT ); Tue, 31 Jul 2012 10:29:51 -0400 Message-ID: <5017EBDC.6010005@linaro.org> Date: Tue, 31 Jul 2012 15:29:48 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, olalilja@yahoo.se, STEricsson_nomadik_linux@list.st.com, lrg@ti.com Subject: Re: [PATCH 5/6] ARM: ux500: Enable HIGHMEM on all mop500 platforms References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-10-git-send-email-lee.jones@linaro.org> <20120731135614.GR6802@n2100.arm.linux.org.uk> In-Reply-To: <20120731135614.GR6802@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/12 14:56, Russell King - ARM Linux wrote: > On Tue, Jul 31, 2012 at 02:31:30PM +0100, Lee Jones wrote: >> The current kernel commandline for ux500 based devices includes >> hard-coded allocations for things like mali and hwmem, which >> actually run over lowmem. Here we enable highmem in order to >> avoid memory corruption errors. > > Err what? highmem should make no difference if things are being done > correctly. > > In other words, your patch description is too vague to understand what > the problem is and why you have to force highmem on - and nothing should > _require_ highmem. I think I must have misunderstood some advice which was recently given to me. I'll drop the patch. Thanks for reviewing. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog