From: Igor Mitsyanko <i.mitsyanko@samsung.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kwolf@redhat.com, benoit.canet@gmail.com,
wdongxu@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com,
e.voevodin@samsung.com, qemu-devel@nongnu.org, armbru@redhat.com,
andrew.zaborowski@intel.com, kyungmin.park@samsung.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support
Date: Tue, 31 Jul 2012 22:18:57 +0400 [thread overview]
Message-ID: <50182191.6000808@samsung.com> (raw)
In-Reply-To: <CAFEAcA9=Cnp2HaVdTLe5sfvninuFsRfh3mAD7BbgCiDYdbpjdA@mail.gmail.com>
On 07/31/2012 06:56 PM, Peter Maydell wrote:
> On 27 July 2012 20:29, Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
>> + VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, wpgrps_size,
>> + sizeof(unsigned long)),
>
> Isn't this trying to use wpgrps_size as the number of unsigned longs in
> the bitmap, when it's actually the size of the bitmap in bits?
>
> (Does this correctly work in migration between 32 and 64 bit systems
> where 'unsigned long' is a different size? How about between a little
> endian 32 bit system and a big endian 64 bit system? I don't know
> enough about the vmstate macros to be confident here...)
>
> -- PMM
>
>
You're right, bitmap_new() can allocated buffers of different size for
the same number of bits but different sizeof(long) value. Maybe always
align allocated buffer size to 8 byte? Endianess seems like even bigger
issue.. Looks like we need to think of something else here.
next prev parent reply other threads:[~2012-07-31 18:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 19:29 [Qemu-devel] [PATCH V4 00/12] SD save/load support, SD qomification and bug fixes Igor Mitsyanko
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield Igor Mitsyanko
2012-07-31 14:25 ` Peter Maydell
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 02/12] hw/sd.c: make sd_wp_addr() accept 64 bit address argument Igor Mitsyanko
2012-07-31 14:25 ` Peter Maydell
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 03/12] hw/sd.c: introduce wrapper for conversion address to wp group Igor Mitsyanko
2012-07-31 14:27 ` Peter Maydell
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase Igor Mitsyanko
2012-07-31 9:29 ` Markus Armbruster
2012-07-31 10:19 ` Igor Mitsyanko
2012-07-31 14:34 ` Peter Maydell
2012-07-31 15:13 ` Igor Mitsyanko
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 05/12] hw/sd.c: convert binary variables to bool Igor Mitsyanko
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 06/12] hw/sd.c: make sd_dataready() return bool Igor Mitsyanko
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 07/12] hw/sd.c: make sd_wp_addr() " Igor Mitsyanko
2012-07-31 14:39 ` Peter Maydell
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support Igor Mitsyanko
2012-07-31 9:33 ` Markus Armbruster
2012-07-31 10:27 ` Igor Mitsyanko
2012-07-31 14:56 ` Peter Maydell
2012-07-31 18:18 ` Igor Mitsyanko [this message]
2012-08-08 15:56 ` Peter Maydell
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object Igor Mitsyanko
2012-07-31 9:45 ` Markus Armbruster
2012-07-31 9:59 ` Peter Maydell
2012-07-31 14:48 ` Igor Mitsyanko
2012-07-31 15:29 ` Markus Armbruster
2012-07-31 16:17 ` Peter Maydell
2012-07-31 17:09 ` Igor Mitsyanko
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods Igor Mitsyanko
2012-07-31 15:43 ` Peter Maydell
2012-07-31 17:33 ` Igor Mitsyanko
2012-07-31 17:47 ` Peter Maydell
2012-07-31 18:03 ` Igor Mitsyanko
2012-07-31 18:15 ` Anthony Liguori
2012-07-31 18:33 ` Igor Mitsyanko
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 11/12] SD card: introduce "spi" property for SD card objects Igor Mitsyanko
2012-07-31 9:54 ` Markus Armbruster
2012-07-31 12:19 ` Andreas Färber
2012-07-31 12:53 ` Paolo Bonzini
2012-07-27 19:29 ` [Qemu-devel] [PATCH V4 12/12] hw/sd.c: introduce SD card "drive" property Igor Mitsyanko
2012-08-10 15:06 ` [Qemu-devel] [PATCH V4 00/12] SD save/load support, SD qomification and bug fixes Peter Maydell
2012-08-10 16:23 ` Igor Mitsyanko
2012-10-25 15:47 ` Peter Maydell
2012-10-25 18:46 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50182191.6000808@samsung.com \
--to=i.mitsyanko@samsung.com \
--cc=andrew.zaborowski@intel.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=e.voevodin@samsung.com \
--cc=kwolf@redhat.com \
--cc=kyungmin.park@samsung.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.