All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@linux-foundation.org
Subject: Removing 'pos' from hlist iterators
Date: Tue, 31 Jul 2012 22:39:37 +0200	[thread overview]
Message-ID: <50184289.7080108@gmail.com> (raw)

Hi all,

I was working on code that uses hlists, and noticed something odd.

While list_for_each_entry needs 3 parameters (type*, head, member), hlist_for_each_entry needs 4 (everything like hlist_for_each + 'pos').

pos and tpos both serve as iterators in this case, and I think that there's no real need for this redundancy.

Would it make sense removing 'pos' out of the hlist iterators to make it more list the list iterators? The downside I see here is that it'll cause a lot of one-line changes all across the code since there are quite a few call sites.


Thanks,
Sasha

                 reply	other threads:[~2012-07-31 20:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50184289.7080108@gmail.com \
    --to=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.