From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v3 2/2] ARM: EXYNOS: Add Gscaler device from DT Date: Wed, 01 Aug 2012 10:18:30 +0200 Message-ID: <5018E656.3070803@samsung.com> References: <1342789723-3949-1-git-send-email-shaik.ameer@samsung.com> <1342789723-3949-3-git-send-email-shaik.ameer@samsung.com> <033301cd6fb0$7ac4af90$704e0eb0$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:37030 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858Ab2HAISd (ORCPT ); Wed, 1 Aug 2012 04:18:33 -0400 Received: from eusync3.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8200MK1HRUZP50@mailout3.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 01 Aug 2012 09:19:06 +0100 (BST) Received: from [106.116.147.32] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M8200BZSHQVCW00@eusync3.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 01 Aug 2012 09:18:31 +0100 (BST) In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: Thomas Abraham , Shaik Ameer Basha , linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, sy0816.kang@samsung.com, olofj@google.com, thomas.ab@samsung.com, sachin.kamat@linaro.org, joshi@samsung.com, shaik.samsung@gmail.com On 08/01/2012 09:48 AM, Thomas Abraham wrote: > On 1 August 2012 12:10, Kukjin Kim wrote: >> Shaik Ameer Basha wrote: > > [...] > >>> +* Samsung Exynos5 Gscaler device >>> + >>> +Gscaler is used for scaling and color space conversion on EXYNOS5 SoCs. >>> + >>> +Required properties: >>> +- compatible: should be "samsung,exynos5250-gsc" >> >> IMO, should be "samsung,exynos5-gsc" because upcoming EXYNOS5 SoCs can use >> same gscaler driver. In addition to the below explanation, perhaps it's obvious, but the driver can claim compatibility with multiple devices, i.e. match with multiple 'compatible' properties. Regards, Sylwester > The compatible string should always be specific and it should clearly > identify the type of the controller. If there are other variants of > the GSC controller in previous of upcoming SoC's, then those > controllers will have a different compatible value. > > This allows device drivers to know the type of the controller and > handle the differences among them. And, the node in the dts/dtsi file > should always claim compatibility to the base version of the > controller that the platform supports. > > So the compatible value "samsung,exynos5250-gsc" is right one. If a > new SoC in the Exynos5 family has the same GSC controller as that in > Exynos5250 (no difference at all), then GSC device node in its dts > file can continue to claim compatibility to Exynos5250 type. The > "samsung,s3c2410-wdt is an example of this case which has been used on > all Samsung SoC's . > > Thanks, > Thomas.