From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH for v3.6] Fix mem2mem_testdev querycap regression
Date: Wed, 01 Aug 2012 11:19:33 +0200 [thread overview]
Message-ID: <5018F4A5.2000200@samsung.com> (raw)
In-Reply-To: <201208010932.33074.hverkuil@xs4all.nl>
On 08/01/2012 09:32 AM, Hans Verkuil wrote:
> Trival but important patch.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> diff --git a/drivers/media/video/mem2mem_testdev.c b/drivers/media/video/mem2mem_testdev.c
> index 7efe9ad..0b91a5c 100644
> --- a/drivers/media/video/mem2mem_testdev.c
> +++ b/drivers/media/video/mem2mem_testdev.c
> @@ -431,7 +431,7 @@ static int vidioc_querycap(struct file *file, void *priv,
> strncpy(cap->driver, MEM2MEM_NAME, sizeof(cap->driver) - 1);
> strncpy(cap->card, MEM2MEM_NAME, sizeof(cap->card) - 1);
> strlcpy(cap->bus_info, MEM2MEM_NAME, sizeof(cap->bus_info));
> - cap->capabilities = V4L2_CAP_VIDEO_M2M | V4L2_CAP_STREAMING;
> + cap->device_caps = V4L2_CAP_VIDEO_M2M | V4L2_CAP_STREAMING;
> cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
> return 0;
> }
Oops, my bad. Thanks for fixing this Hans!
Regards,
Sylwester
prev parent reply other threads:[~2012-08-01 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 7:32 [PATCH for v3.6] Fix mem2mem_testdev querycap regression Hans Verkuil
2012-08-01 9:19 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018F4A5.2000200@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.