From: Hannes Reinecke <hare@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] megasas: static SAS addresses
Date: Wed, 01 Aug 2012 11:19:37 +0200 [thread overview]
Message-ID: <5018F4A9.4000504@suse.de> (raw)
In-Reply-To: <1343812324-17560-1-git-send-email-hare@suse.de>
(Bad style to reply to my own post. I know.)
On 08/01/2012 11:12 AM, Hannes Reinecke wrote:
> This patch introduces a new property 'sas_address' which
> allows the user to specify the SAS address for the HBA.
> The default address it taken from the qumranet IEEE number
> and the pci slot address. That ensures it'll be unique
> and reproduceable locally.
>
> The port addresses are now calculated based on the magic
> number 0x1221 (which is found in real hardware, too) plus
> the device number.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Andreas Faerber <afaerber@suse.de>
> Cc: Anthony Liguori <aliguori@codemonkey.ws>
> Cc: Alexander Graf <agraf@suse.de>
> ---
> hw/megasas.c | 63 ++++++++++++++++++++++++++++++++++++++++++---------------
> hw/mfi.h | 1 +
> 2 files changed, 47 insertions(+), 17 deletions(-)
>
> diff --git a/hw/megasas.c b/hw/megasas.c
> index 9a0eab1..e709d4d 100644
> --- a/hw/megasas.c
> +++ b/hw/megasas.c
> @@ -38,6 +38,8 @@
> #define MEGASAS_MAX_SECTORS 0xFFFF /* No real limit */
> #define MEGASAS_MAX_ARRAYS 128
>
> +#define IEEE_COMPANY_QUMRANET 0x001A4AULL
> +
Something worth of note:
To generate a valid SAS address I need an IEEE number.
I seem to remember Qumranet donated their PCI id for KVM use.
I don't actually know if that donation extends to the IEEE number,
too. If not then obviously I would need to use another one here.
Who would be best in a position to answer this?
Paolo? Someone at RH should know ...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2012-08-01 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 9:12 [Qemu-devel] [PATCH] megasas: static SAS addresses Hannes Reinecke
2012-08-01 9:19 ` Hannes Reinecke [this message]
2012-08-01 9:23 ` Paolo Bonzini
2012-08-01 10:04 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018F4A9.4000504@suse.de \
--to=hare@suse.de \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.