Re: [PATCH 1/2] NFS: Fix a number of bugs in the idmapper

[Steve Dickson <SteveD@redhat.com>]

On 07/31/2012 01:11 PM, J. Bruce Fields wrote:
> On Tue, Jul 31, 2012 at 12:37:08PM -0400, bfields wrote:
>> On Tue, Jul 31, 2012 at 03:07:42PM +0000, Myklebust, Trond wrote:
>>> We don't expect people to be running both types of idmapper at the same
>>> time. Normally, the distribution will set up one or the other. However
>>> if both idmappers do happen to be configured, then we want to always
>>> choose the non-legacy type...
>>
>> On a quick check....  It looks like F17 has /usr/sbin/nfsidmap, and also
>> runs rpc.idmapd for the server.  While rpc.idmap does have a "-S"
>> option, it's not using that.
>>
>> But that should be easy to fix--I'll go look....
> 
> Steve, this, or do we want to modify the default value of RPCIDMAPDARGS
> in nfs.sysconfig?
Actually that looks like a good idea.. I'll make that happen... but
it will be a Fedora only thing... 

steved.
> 
> --b.
> 
> diff --git a/nfs-idmap.service b/nfs-idmap.service
> index 872ae09..93c1b3a 100644
> --- a/nfs-idmap.service
> +++ b/nfs-idmap.service
> @@ -7,7 +7,7 @@ After=nfs-server.service
>  Type=forking
>  StandardError=syslog+console
>  EnvironmentFile=-/etc/sysconfig/nfs
> -ExecStart=/usr/sbin/rpc.idmapd $RPCIDMAPDARGS
> +ExecStart=/usr/sbin/rpc.idmapd -S $RPCIDMAPDARGS
>  
>  [Install]
>  WantedBy=nfs.target
> diff --git a/nfs.sysconfig b/nfs.sysconfig
> index 2d33cf3..4baa0c3 100644
> --- a/nfs.sysconfig
> +++ b/nfs.sysconfig
> @@ -24,7 +24,7 @@ RPCMOUNTDOPTS=""
>  STATDARG=""
>  #
>  # Optional arguments passed to rpc.idmapd. See rpc.idmapd(8)
> -RPCIDMAPDARGS=""
> +RPCIDMAPDARGS="-S"
>  #
>  # Optional arguments passed to rpc.gssd. See rpc.gssd(8)
>  RPCGSSDARGS=""
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html