All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 01/19] tinylogin: use new update-alternatives
Date: Wed, 1 Aug 2012 10:12:54 -0500	[thread overview]
Message-ID: <50194776.4080601@windriver.com> (raw)
In-Reply-To: <1343830340-25351-2-git-send-email-morgan.little@windriver.com>

On 8/1/12 9:12 AM, Morgan Little wrote:
>
> Signed-off-by: Morgan Little <morgan.little@windriver.com>
> ---
>   meta/recipes-core/tinylogin/tinylogin_1.4.bb |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-core/tinylogin/tinylogin_1.4.bb b/meta/recipes-core/tinylogin/tinylogin_1.4.bb
> index 195f0c7..b86141f 100644
> --- a/meta/recipes-core/tinylogin/tinylogin_1.4.bb
> +++ b/meta/recipes-core/tinylogin/tinylogin_1.4.bb
> @@ -7,7 +7,7 @@
>   and groups on an embedded system."
>   HOMEPAGE = "http://tinylogin.busybox.net/"
>   LICENSE = "GPLv2"
>   LIC_FILES_CHKSUM="file://LICENSE;md5=f1060fa3a366f098b5b1d8c2077ba269"
> -PR = "r8"
> +PR = "r9"
>
>   inherit update-alternatives
>
> @@ -42,7 +42,7 @@
>   do_install_append () {
>           mv ${D}${base_sbindir}/getty ${D}${base_sbindir}/getty.${BPN}
>   }
>
> -ALTERNATIVE_NAME = "getty"
> -ALTERNATIVE_LINK = "${base_sbindir}/getty"
> -ALTERNATIVE_PATH = "${base_sbindir}/getty.${BPN}"
> +ALTERNATIVE_${PN} = "getty"
> +ALTERNATIVE_LINK_NAME[getty] = "${base_sbindir}/getty"
> +ALTERNATIVE_TARGET[getty] =  "${base_sbindir}/getty.${BPN}"
>   ALTERNATIVE_PRIORITY = "80"
>

The above will work.. but it would be better to (perhaps a second commit?):

remove the do_install_append, it is no longer necessary

Once you do that, then you may remove the "ALTERNARTIVE_TARGET[getty]" that you 
added, as it will automatically be configured as such by the update-alternatives 
class.

--Mark



  reply	other threads:[~2012-08-01 15:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01 14:12 This is a series of patches to update recipes that display warnings about the Morgan Little
2012-08-01 14:12 ` [PATCH 01/19] tinylogin: use new update-alternatives Morgan Little
2012-08-01 15:12   ` Mark Hatle [this message]
2012-08-01 14:12 ` [PATCH 02/19] patch: " Morgan Little
2012-08-01 15:13   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 03/19] ubootchart_svn: " Morgan Little
2012-08-01 14:12 ` [PATCH 04/19] gawk: " Morgan Little
2012-08-01 14:12 ` [PATCH 05/19] less: " Morgan Little
2012-08-01 15:14   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 06/19] mingetty: " Morgan Little
2012-08-01 14:12 ` [PATCH 07/19] mktemp: " Morgan Little
2012-08-01 15:15   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 08/19] msmtp: " Morgan Little
2012-08-01 14:12 ` [PATCH 09/19] sed: " Morgan Little
2012-08-01 15:16   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 10/19] time: " Morgan Little
2012-08-01 15:16   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 11/19] wget: " Morgan Little
2012-08-01 15:16   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 12/19] which: " Morgan Little
2012-08-01 15:17   ` Mark Hatle
2012-08-01 14:12 ` [PATCH 13/19] metacity: " Morgan Little
2012-08-01 14:12 ` [PATCH 14/19] matchbox-session: " Morgan Little
2012-08-01 14:12 ` [PATCH 15/19] matchbox-wm-2: " Morgan Little
2012-08-01 14:12 ` [PATCH 16/19] mini-x-session: " Morgan Little
2012-08-01 14:12 ` [PATCH 17/19] mutter: " Morgan Little
2012-08-01 14:12 ` [PATCH 18/19] powertop: " Morgan Little
2012-08-01 14:12 ` [PATCH 19/19] rxvt-unicode: " Morgan Little
2012-08-01 14:31 ` This is a series of patches to update recipes that display warnings about the Martin Jansa
2012-08-01 14:40   ` Little, Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50194776.4080601@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.