From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] kvm tools: don't bother tracking is_dir
Date: Wed, 01 Aug 2012 20:10:00 +0200
Message-ID: <501970F8.8060705@gmail.com>
References: <1342974594-31317-1-git-send-email-levinsasha928@gmail.com> <1342974594-31317-5-git-send-email-levinsasha928@gmail.com> <alpine.LFD.2.02.1207310924410.2405@tux.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: mingo@elte.hu, gorcunov@gmail.com, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bk0-f46.google.com ([209.85.214.46]:59938 "EHLO
	mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754531Ab2HASJb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 1 Aug 2012 14:09:31 -0400
Received: by bkwj10 with SMTP id j10so3906620bkw.19
        for <kvm@vger.kernel.org>; Wed, 01 Aug 2012 11:09:30 -0700 (PDT)
In-Reply-To: <alpine.LFD.2.02.1207310924410.2405@tux.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/31/2012 08:24 AM, Pekka Enberg wrote:
> On Sun, 22 Jul 2012, Sasha Levin wrote:
>> This is something we can calculate on the fly, and doesn't justify the overhead
>> of tracking it all over fid transitions.
>>
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> 
> What kind of overhead are you talking about?

Having to carry it between fids when they are copied/created.

This flag is required in only about 2-3 spots, and I've stumbled on a bunch of issues when writing the dynamic fid allocation due to failure to copy this flag over only when required.