From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH V2 08/10] ARM: OMAP4: Prevent EMU power domain transitioning to OFF when in-use Date: Wed, 1 Aug 2012 14:41:34 -0500 Message-ID: <5019866E.3000100@ti.com> References: <1339104132-26885-1-git-send-email-jon-hunter@ti.com> <1339104132-26885-9-git-send-email-jon-hunter@ti.com> <500028B3.1040309@ti.com> <50045D17.9050704@ti.com> <50171841.40309@ti.com> <501760BF.8070801@ti.com> <5018210A.1040902@ti.com> <50187644.40308@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:53063 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755865Ab2HATlr (ORCPT ); Wed, 1 Aug 2012 15:41:47 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Kevin Hilman , Benoit Cousson , Ming Lei , Will Deacon , Madhav Vij , Santosh Shilimkar , linux-omap , linux-arm Hi Paul, On 08/01/2012 10:36 AM, Paul Walmsley wrote: > Hi Jon et al, >=20 > Here's what I'm planning to queue here. The only changes from what J= on > posted are the patch changelog and some checkpatch fixes. If anyone > has any final comments, please let me know. >=20 >=20 > - Paul >=20 > From: Paul Walmsley > Date: Wed, 1 Aug 2012 09:11:20 -0600 > Subject: [PATCH] ARM: OMAP2+: clockdomain/hwmod: add workaround for E= MU > clockdomain idle problems >=20 > The idle status of the IP blocks and clocks inside the EMU clockdomai= n > isn't taken into account by the PRCM hardware when deciding whether > the clockdomain is idle. Add a workaround flag in the clockdomain > code, CLKDM_MISSING_IDLE_REPORTING, to deal with this problem, and ad= d > the code necessary to support it. >=20 > If CLKDM_MISSING_IDLE_REPORTING is set on a clockdomain, the > clockdomain will be forced active whenever an IP block inside that > clockdomain is in use, even if the clockdomain supports > hardware-supervised idle. When the kernel indicates that the last > active IP block inside the clockdomain is no longer used, the > clockdomain will be forced idle, or, if that mode is not supported in > the hardware, it will be placed into hardware-supervised idle. >=20 > This patch is an equal collaboration with Jon Hunter > . Ming Lei , Will Deacon > , Madhav Vij , Kevin Hilman > , Beno=EEt Cousson , and Santosh > Shilimkar all made essential contributions > to the understanding of EMU clockdomain power management on OMAP. >=20 > Signed-off-by: Paul Walmsley Thanks for sending out. You can add my ... Tested-by: Jon Hunter I have tested this on omap3430 (beagle), omap4430 (blaze) and omap4460 (panda) with perf and my PMU series [1]. I have verified that the EMU power domain is transitioning correctly on these platforms. For OMAP343= 0 I checked that CORE retention is still being achieved with this change. Cheers Jon [1] git@gitorious.org:linux-omap-dev/linux-omap-dev.git -b dev-pmu -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon-hunter@ti.com (Jon Hunter) Date: Wed, 1 Aug 2012 14:41:34 -0500 Subject: [PATCH V2 08/10] ARM: OMAP4: Prevent EMU power domain transitioning to OFF when in-use In-Reply-To: References: <1339104132-26885-1-git-send-email-jon-hunter@ti.com> <1339104132-26885-9-git-send-email-jon-hunter@ti.com> <500028B3.1040309@ti.com> <50045D17.9050704@ti.com> <50171841.40309@ti.com> <501760BF.8070801@ti.com> <5018210A.1040902@ti.com> <50187644.40308@ti.com> Message-ID: <5019866E.3000100@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On 08/01/2012 10:36 AM, Paul Walmsley wrote: > Hi Jon et al, > > Here's what I'm planning to queue here. The only changes from what Jon > posted are the patch changelog and some checkpatch fixes. If anyone > has any final comments, please let me know. > > > - Paul > > From: Paul Walmsley > Date: Wed, 1 Aug 2012 09:11:20 -0600 > Subject: [PATCH] ARM: OMAP2+: clockdomain/hwmod: add workaround for EMU > clockdomain idle problems > > The idle status of the IP blocks and clocks inside the EMU clockdomain > isn't taken into account by the PRCM hardware when deciding whether > the clockdomain is idle. Add a workaround flag in the clockdomain > code, CLKDM_MISSING_IDLE_REPORTING, to deal with this problem, and add > the code necessary to support it. > > If CLKDM_MISSING_IDLE_REPORTING is set on a clockdomain, the > clockdomain will be forced active whenever an IP block inside that > clockdomain is in use, even if the clockdomain supports > hardware-supervised idle. When the kernel indicates that the last > active IP block inside the clockdomain is no longer used, the > clockdomain will be forced idle, or, if that mode is not supported in > the hardware, it will be placed into hardware-supervised idle. > > This patch is an equal collaboration with Jon Hunter > . Ming Lei , Will Deacon > , Madhav Vij , Kevin Hilman > , Beno?t Cousson , and Santosh > Shilimkar all made essential contributions > to the understanding of EMU clockdomain power management on OMAP. > > Signed-off-by: Paul Walmsley Thanks for sending out. You can add my ... Tested-by: Jon Hunter I have tested this on omap3430 (beagle), omap4430 (blaze) and omap4460 (panda) with perf and my PMU series [1]. I have verified that the EMU power domain is transitioning correctly on these platforms. For OMAP3430 I checked that CORE retention is still being achieved with this change. Cheers Jon [1] git at gitorious.org:linux-omap-dev/linux-omap-dev.git -b dev-pmu