From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwfzH-0003qS-M3 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 16:57:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwfzG-0001rk-DE for qemu-devel@nongnu.org; Wed, 01 Aug 2012 16:57:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49600 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwfzG-0001rf-3O for qemu-devel@nongnu.org; Wed, 01 Aug 2012 16:57:46 -0400 Message-ID: <50199841.8020507@suse.de> Date: Wed, 01 Aug 2012 22:57:37 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> <87zk6elisw.fsf@codemonkey.ws> <50195034.9050201@suse.de> <874nom8o5q.fsf@codemonkey.ws> <50198508.10303@suse.de> <87pq7acrdf.fsf@codemonkey.ws> In-Reply-To: <87pq7acrdf.fsf@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: peter.maydell@linaro.org, ehabkost@redhat.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, Igor Mammedov Am 01.08.2012 22:02, schrieb Anthony Liguori: > Andreas F=C3=A4rber writes: >=20 >> Am 01.08.2012 20:25, schrieb Anthony Liguori: >>> Andreas F=C3=A4rber writes: >>> >>>> Am 01.08.2012 17:43, schrieb Anthony Liguori: >>>>> Igor Mammedov writes: >>>>> >>>>>> v2: >>>>>> ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_ne= w_cpu(), >>>>>> to keep cpu_init implementation in -softmmu and -user targets th= e same >>>>>> in single place and maintanable. >>>>>> >>>>>> v3: >>>>>> reuse cpu_is_bsp() rather than open code check if apicbase has B= SP bit set >>>>>> >>>>>> tree for testing: >>>>>> https://github.com/imammedo/qemu/tree/x86_reset_v3 >>>>>> >>>>>> comiple & run tested with x86_64-linux-user, x86_64-softmmu target= s >>>>>> >>>>>> Igor Mammedov (2): >>>>>> target-i386: move cpu halted decision into x86_cpu_reset >>>>>> target-i386: move cpu_reset and reset callback to cpu.c >>>>> >>>>> Applied all. Thanks. >>>> >>>> So do you intend to refactor all machines accordingly or leave it >>>> inconsistent now? >>> >>> Are you asking me? >>> >>> No, I have no intention of touching any other machine. We're not goi= ng >>> to limit cleaning up target-i386 unless every other machine is cleane= d >>> up too. >>> >>> Reset logic should live in the CPU. Seems like a no-brainer to me. >> >> Yes, I'm asking you, since you replied and applied the series without >> responding to my review comment on patch 2/2. You probably applied it >> locally before reading my comments but then I would still have expecte= d >> a reply on how to proceed in light of those comments: >=20 > No, I saw your comment, although I had already decided to apply it by > then. If you did read it then you forgot my Reviewed-by on 1/2. :( Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg