All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <method@manicmethod.com>
To: selinux@tycho.nsa.gov
Cc: Joshua Brindle <jbrindle@tresys.com>
Subject: Re: [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
Date: Wed, 01 Aug 2012 22:39:26 -0400	[thread overview]
Message-ID: <5019E85E.1070402@manicmethod.com> (raw)
In-Reply-To: <1343874989-13155-1-git-send-email-method@manicmethod.com>

Note, I have no idea why this just started happening but it is 
consistent on my 4.1.1_r3 checkout. I don't know what the ramifications 
of changing the mountpoint are (e.g., is that used by something other 
than selabel_lookup?) so I haven't submitted it to AOSP.

Joshua Brindle wrote:
> From: Joshua Brindle<jbrindle@tresys.com>
>
> selabel_lookup requires the mountpoint start with a '/' to match specifications in the file_context file. Change mkyaffs2image call to add a '/' to the mount point argument
>
> Change-Id: I255b661822401f9253ef58a2a4bdada85fc96b23
>
> Signed-off-by: Joshua Brindle<jbrindle@tresys.com>
> ---
>   tools/releasetools/build_image.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/releasetools/build_image.py b/tools/releasetools/build_image.py
> index a615d1a..610e634 100755
> --- a/tools/releasetools/build_image.py
> +++ b/tools/releasetools/build_image.py
> @@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict, out_file):
>       build_command.append(out_file)
>       if "selinux_fc" in prop_dict:
>         build_command.append(prop_dict["selinux_fc"])
> -      build_command.append(prop_dict["mount_point"])
> +      build_command.append("/%s" % prop_dict["mount_point"])
>
>     print "Running: ", " ".join(build_command)
>     p = subprocess.Popen(build_command);

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2012-08-02  2:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02  2:36 [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point Joshua Brindle
2012-08-02  2:39 ` Joshua Brindle [this message]
2012-08-02 10:04   ` Robert Craig
2012-08-02 13:06     ` Stephen Smalley
  -- strict thread matches above, loose matches on Subject: below --
2012-08-02  2:32 Joshua Brindle
2012-08-02  2:38 ` Joshua Brindle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5019E85E.1070402@manicmethod.com \
    --to=method@manicmethod.com \
    --cc=jbrindle@tresys.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.