From: Erez Shitrit <erezsh@mellanox.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>, <davem@davemloft.net>,
<roland@kernel.org>, <netdev@vger.kernel.org>, <ali@mellanox.com>,
<sean.hefty@intel.com>, Erez Shitrit <erezsh@mellanox.co.il>
Subject: Re: [PATCH V2 08/12] net/eipoib: Add ethtool file support
Date: Thu, 2 Aug 2012 11:35:42 +0300 [thread overview]
Message-ID: <501A3BDE.1070509@mellanox.com> (raw)
In-Reply-To: <1343866955.2602.66.camel@bwh-desktop.uk.solarflarecom.com>
On 8/2/2012 3:22 AM, Ben Hutchings wrote:
> On Wed, 2012-08-01 at 20:09 +0300, Or Gerlitz wrote:
>> From: Erez Shitrit <erezsh@mellanox.co.il>
>>
>> Via ethtool the driver describes its version, ABI version, on what PIF
>> interface it runs and various statistics.
> [...]
>> --- /dev/null
>> +++ b/drivers/net/eipoib/eth_ipoib_ethtool.c
> [...]
>> +static void parent_ethtool_get_drvinfo(struct net_device *parent_dev,
>> + struct ethtool_drvinfo *drvinfo)
>> +{
>> + struct parent *parent = netdev_priv(parent_dev);
>> +
>> + strncpy(drvinfo->driver, DRV_NAME, 32);
>> +
>> + strncpy(drvinfo->version, DRV_VERSION, 32);
>> +
>> + strncpy(drvinfo->bus_info, parent->ipoib_main_interface,
>> + ETHTOOL_BUSINFO_LEN);
> These must be null-terminated; therefore use strlcpy().
ok, will fix.
>> + /* indicates ABI version */
>> + snprintf(drvinfo->fw_version, 32, "%d", EIPOIB_ABI_VER);
> [...]
>
> This is an abuse of fw_version.
>
> Ben.
we took the idea from the bonding driver,
(snprintf(drvinfo->fw_version, 32, "%d", BOND_ABI_VERSION);)
Do you have any idea where can we keep the abi version?
Thanks, Erez
next prev parent reply other threads:[~2012-08-02 8:35 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 17:09 [PATCH V2 00/12] Add Ethernet IPoIB driver Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 01/12] IB/ipoib: Add rtnl_link_ops support Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 02/12] IB/ipoib: Add support for clones / multiple childs on the same partition Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 03/12] include/linux: Add private flags for IPoIB interfaces Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 04/12] IB/ipoib: Add support for acting as VIF Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 05/12] net: Add ndo_set_vif_param operation to serve eIPoIB VIFs Or Gerlitz
2012-08-02 0:17 ` Ben Hutchings
2012-08-02 8:25 ` Erez Shitrit
2012-08-01 17:09 ` [PATCH V2 06/12] net/core: Add rtnetlink support to vif parameters Or Gerlitz
2012-08-02 0:20 ` Ben Hutchings
2012-08-02 15:29 ` Erez Shitrit
2012-08-01 17:09 ` [PATCH V2 07/12] net/eipoib: Add private header file Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 08/12] net/eipoib: Add ethtool file support Or Gerlitz
2012-08-02 0:22 ` Ben Hutchings
2012-08-02 8:35 ` Erez Shitrit [this message]
2012-08-02 15:42 ` Ben Hutchings
2012-08-01 17:09 ` [PATCH V2 09/12] net/eipoib: Add main driver functionality Or Gerlitz
2012-08-02 17:15 ` Eric W. Biederman
2012-08-03 20:31 ` Ali Ayoub
2012-08-03 21:33 ` David Miller
2012-08-03 22:39 ` Ali Ayoub
2012-08-03 23:36 ` David Miller
2012-08-04 21:23 ` Or Gerlitz
2012-08-04 21:44 ` Or Gerlitz
2012-08-04 23:19 ` Eric W. Biederman
2012-08-07 0:14 ` Ali Ayoub
2012-08-07 0:44 ` Eric W. Biederman
2012-08-07 1:21 ` Re[2]: " Naoto MATSUMOTO
2012-08-15 9:10 ` Re[3]: " Naoto MATSUMOTO
2012-08-07 3:33 ` Eric W. Biederman
2012-08-08 6:04 ` Or Gerlitz
2012-08-08 8:36 ` Eric W. Biederman
2012-08-09 4:06 ` Or Gerlitz
2012-08-12 14:05 ` Michael S. Tsirkin
2012-08-07 3:37 ` Joseph Glanville
2012-08-08 7:32 ` Or Gerlitz
2012-08-08 9:17 ` Eric W. Biederman
2012-08-09 4:34 ` Or Gerlitz
2012-08-12 10:36 ` Michael S. Tsirkin
2012-08-04 0:02 ` Ali Ayoub
2012-08-04 0:05 ` David Miller
2012-08-04 1:34 ` Eric W. Biederman
2012-08-04 21:33 ` Or Gerlitz
2012-08-05 18:50 ` Michael S. Tsirkin
2012-08-08 5:23 ` Or Gerlitz
2012-08-12 10:22 ` Michael S. Tsirkin
2012-08-12 13:09 ` Or Gerlitz
2012-08-12 13:41 ` Michael S. Tsirkin
2012-08-12 13:15 ` Or Gerlitz
2012-08-12 13:55 ` Michael S. Tsirkin
2012-08-12 14:13 ` Or Gerlitz
2012-08-12 20:54 ` Michael S. Tsirkin
2012-08-14 8:44 ` Or Gerlitz
2012-08-20 18:57 ` Michael S. Tsirkin
2012-08-23 6:45 ` Or Gerlitz
2012-08-14 7:41 ` Or Gerlitz
2012-08-12 10:54 ` Michael S. Tsirkin
2012-08-12 13:19 ` Or Gerlitz
2012-08-12 15:40 ` Eric W. Biederman
2012-08-13 8:33 ` Or Gerlitz
2012-08-13 16:08 ` Eric W. Biederman
2012-09-03 20:53 ` Or Gerlitz
2012-09-03 21:22 ` Michael S. Tsirkin
2012-09-04 18:50 ` Or Gerlitz
2012-09-04 19:31 ` Eric W. Biederman
2012-09-04 19:47 ` Or Gerlitz
2012-09-04 21:21 ` Michael S. Tsirkin
2012-09-04 18:57 ` Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 10/12] net/eipoib: Add sysfs support Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 11/12] net/eipoib: Add Makefile, Kconfig and MAINTAINERS entries Or Gerlitz
2012-08-01 17:09 ` [PATCH V2 12/12] IB/ipoib: Add support for transmission of skbs w.o dst/neighbour Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A3BDE.1070509@mellanox.com \
--to=erezsh@mellanox.com \
--cc=ali@mellanox.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=erezsh@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.