From: Avi Kivity <avi@redhat.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] kbuild: kvm: make export of linux/kvm_para.h unconditional
Date: Thu, 02 Aug 2012 17:19:20 +0300 [thread overview]
Message-ID: <501A8C68.9030001@redhat.com> (raw)
In-Reply-To: <20120802122550.GD9838@mudshark.cambridge.arm.com>
On 08/02/2012 03:25 PM, Will Deacon wrote:
> On Thu, Jul 26, 2012 at 02:44:14PM +0100, Will Deacon wrote:
>> The asm-generic version of kvm_para.h is always exported, confusing the
>> Kbuild wildcarding that tries to detect whether the source architecture
>> is exporting the header, since asm-* matches the generic version.
>>
>> This patch unconditionally exports linux/kvm_para.h and fixes the few
>> remaining architectures without asm/kvm_para.h to use the generic
>> version. I also took the liberty of removing some dead lines from the
>> wildcarding which was searcing for asm-$(SRCARCH) directores under
>> $(srctree).
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Avi Kivity <avi@redhat.com>
>> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Will Deacon <will.deacon@arm.com>
>> ---
>
> Any further comments on this? It fixes header generation for me, so it would
> be nice to see it merged.
Can you get it reviewed by someone who is familiar with this? This is
probably the third fix for the this issue.
Arnd?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-02 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 13:44 [PATCH] kbuild: kvm: make export of linux/kvm_para.h unconditional Will Deacon
2012-08-02 12:25 ` Will Deacon
2012-08-02 14:19 ` Avi Kivity [this message]
2012-08-02 20:29 ` Sam Ravnborg
2012-08-03 12:51 ` Will Deacon
2012-08-03 13:02 ` Sam Ravnborg
2012-08-03 13:11 ` Arnd Bergmann
2012-09-16 19:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A8C68.9030001@redhat.com \
--to=avi@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.