From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swxba-0005wc-N4 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 11:46:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwxbY-0004OE-7J for qemu-devel@nongnu.org; Thu, 02 Aug 2012 11:46:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44354 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwxbX-0004Nk-TE for qemu-devel@nongnu.org; Thu, 02 Aug 2012 11:46:28 -0400 Message-ID: <501AA0D0.3070800@suse.de> Date: Thu, 02 Aug 2012 17:46:24 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1342609849-12618-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Christian Borntraeger Cc: Peter Maydell , qemu-devel@nongnu.org, patches@linaro.org Am 02.08.2012 17:41, schrieb Peter Maydell: > Ping? Alex? Christian? >=20 > -- PMM >=20 > On 18 July 2012 12:10, Peter Maydell wrote: >> The code creating the symlink from linux-headers/asm to the >> architecture specific linux-headers/asm-$arch directory was >> implicitly hardcoding a list of KVM supporting architectures. >> Add a default case for the common "Linux architecture name and >> QEMU CPU name match" case, so future architectures will only >> need to add code if they've managed to get mismatched names. >> >> Signed-off-by: Peter Maydell >> --- >> This means there's now only one place where configure has a >> list of KVM enabled targets (the check where we set CONFIG_KVM). >> I think we have to have one list, but we don't need to have >> more than one... >> >> NB: this patch means we'll now set up an asm/ link for >> s390 as well as s390x. That should be harmless (s390 can't be >> trying to include any headers from asm/ or it wouldn't build). >> >> configure | 14 +++++++++++--- >> 1 files changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/configure b/configure >> index 0a3896e..c8d2895 100755 >> --- a/configure >> +++ b/configure >> @@ -3482,15 +3482,23 @@ if test "$linux" =3D "yes" ; then >> mkdir -p linux-headers >> case "$cpu" in >> i386|x86_64) >> - symlink "$source_path/linux-headers/asm-x86" linux-headers/asm >> + linux_arch=3Dx86 >> ;; >> ppcemb|ppc|ppc64) >> - symlink "$source_path/linux-headers/asm-powerpc" linux-headers/as= m >> + linux_arch=3Dpowerpc >> ;; >> s390x) >> - symlink "$source_path/linux-headers/asm-s390" linux-headers/asm >> + linux_arch=3Ds390 >> + ;; >> + *) >> + # For most CPUs the kernel architecture name and QEMU CPU name ma= tch. >> + linux_arch=3D"$cpu" >> ;; >> esac >> + # For non-KVM architectures we will not have asm headers. >> + if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then >> + symlink "$source_path/linux-headers/asm-$linux_arch" linux-he= aders/asm >> + fi >> fi >> >> for target in $target_list; do >> -- >> 1.7.5.4 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg