From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ETIENEN Date: Fri, 03 Aug 2012 09:22:29 +0200 Subject: [Ocfs2-devel] kernel BUG at fs/buffer.c:2886! Linux 3.5.0 In-Reply-To: References: <501313B6.70801@aprogsys.com> <20120730063000.GA4025@dhcp-172-17-9-228.mtv.corp.google.com> <50163B8A.7060509@aprogsys.com> <20120730075333.GC4025@dhcp-172-17-9-228.mtv.corp.google.com> <5016D2C0.6090708@vetienne.net> <501994E8.9070100@aprogsys.com> <501995B7.2030405@vetienne.net> <501A2A7E.10702@aprogsys.com> <501AD4D2.80007@vetienne.net> Message-ID: <501B7C35.1050602@vetienne.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sunil Mushran Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh , Alexander Viro , ocfs2-devel@oss.oracle.com Le 02/08/2012 23:08, Sunil Mushran a ?crit : > On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE > wrote: > > Hi > > based on current git ( commit > 1a9b4993b70fb1884716902774dc9025b457760d ) > and reverting commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 > > commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 > Author: Al Viro > > Date: Thu May 3 10:14:29 2012 -0400 > > ocfs: simplify symlink handling > > and adding the correction from > > https://oss.oracle.com/git/?p=smushran/linux-2.6.git;a=commit;h=a2118b301104a24381b414bc93371d666fe8d43a > > suppres the fallocate bug > > and lead to no oops. At least immediatly. Will let it run some times > > > > Apply this change and re-run: > > diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c > index f1fbb4b..66edce7 100644 > --- a/fs/ocfs2/symlink.c > +++ b/fs/ocfs2/symlink.c > @@ -57,7 +57,7 @@ > static int ocfs2_fast_symlink_readpage(struct file *unused, struct > page *page) > { > struct inode *inode = page->mapping->host; > - struct buffer_head *bh; > + struct buffer_head *bh = NULL; > int status = ocfs2_read_inode_block(inode, &bh); > struct ocfs2_dinode *fe; > const char *link; > latest head with only your two changes is working here, thanks a lot. Running now flowlessly since a few hours. Vincent -------------- next part -------------- An HTML attachment was scrubbed... URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20120803/61814922/attachment.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ETIENEN Subject: Re: kernel BUG at fs/buffer.c:2886! Linux 3.5.0 Date: Fri, 03 Aug 2012 09:22:29 +0200 Message-ID: <501B7C35.1050602@vetienne.net> References: <501313B6.70801@aprogsys.com> <20120730063000.GA4025@dhcp-172-17-9-228.mtv.corp.google.com> <50163B8A.7060509@aprogsys.com> <20120730075333.GC4025@dhcp-172-17-9-228.mtv.corp.google.com> <5016D2C0.6090708@vetienne.net> <501994E8.9070100@aprogsys.com> <501995B7.2030405@vetienne.net> <501A2A7E.10702@aprogsys.com> <501AD4D2.80007@vetienne.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6948588507102693069==" Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh , Alexander Viro , ocfs2-devel@oss.oracle.com To: Sunil Mushran Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com List-Id: linux-fsdevel.vger.kernel.org This is a multi-part message in MIME format. --===============6948588507102693069== Content-Type: multipart/alternative; boundary="------------010300030506090408040603" This is a multi-part message in MIME format. --------------010300030506090408040603 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by acsinet21.oracle.com id q737MfOx026356 Le 02/08/2012 23:08, Sunil Mushran a =E9crit : > On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE > wrote: > > Hi > > based on current git ( commit > 1a9b4993b70fb1884716902774dc9025b457760d ) > and reverting commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 > > commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 > Author: Al Viro > > Date: Thu May 3 10:14:29 2012 -0400 > > ocfs: simplify symlink handling > > and adding the correction from > > https://oss.oracle.com/git/?p=3Dsmushran/linux-2.6.git;a=3Dcommit;h= =3Da2118b301104a24381b414bc93371d666fe8d43a > > suppres the fallocate bug > > and lead to no oops. At least immediatly. Will let it run some time= s > > > > Apply this change and re-run: > > diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c > index f1fbb4b..66edce7 100644 > --- a/fs/ocfs2/symlink.c > +++ b/fs/ocfs2/symlink.c > @@ -57,7 +57,7 @@ > static int ocfs2_fast_symlink_readpage(struct file *unused, struct > page *page) > { > struct inode *inode =3D page->mapping->host; > - struct buffer_head *bh; > + struct buffer_head *bh =3D NULL; > int status =3D ocfs2_read_inode_block(inode, &bh); > struct ocfs2_dinode *fe; > const char *link; > latest head with only your two changes is working here, thanks a lot. Running now flowlessly since a few hours. Vincent --------------010300030506090408040603 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit

Le 02/08/2012 23:08, Sunil Mushran a écrit :
On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE <ve@vetienne.net> wrote:
Hi

based on current git ( commit 1a9b4993b70fb1884716902774dc9025b457760d )
and  reverting commit  ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1

commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Thu May 3 10:14:29 2012 -0400

    ocfs: simplify symlink handling

 and  adding the correction from

https://oss.oracle.com/git/?p=smushran/linux-2.6.git;a=commit;h=a2118b301104a24381b414bc93371d666fe8d43a

suppres the fallocate bug

and lead to no oops. At least immediatly. Will let it run some times


Apply this change and re-run:

diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c
index f1fbb4b..66edce7 100644
--- a/fs/ocfs2/symlink.c
+++ b/fs/ocfs2/symlink.c
@@ -57,7 +57,7 @@
 static int ocfs2_fast_symlink_readpage(struct file *unused, struct page *page)
 {
        struct inode *inode = page->mapping->host;
-       struct buffer_head *bh;
+       struct buffer_head *bh = NULL;
        int status = ocfs2_read_inode_block(inode, &bh);
        struct ocfs2_dinode *fe;
        const char *link;

latest head with only your two changes is working here, thanks a lot. Running now flowlessly since a few hours.

Vincent



--------------010300030506090408040603-- --===============6948588507102693069== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel --===============6948588507102693069==--