From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] Increment buffer used to read first boot sector in order to accomodate space for 4k sector Date: Fri, 03 Aug 2012 16:09:55 +0100 Message-ID: <501BE9C3.1070806@cantab.net> References: <7CE799CC0E4DE04B88D5FDF226E18AC2CDFFB08D0D@LONPMAILBOX01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7CE799CC0E4DE04B88D5FDF226E18AC2CDFFB08D0D@LONPMAILBOX01.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Frediano Ziglio Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 03/08/12 15:50, Frediano Ziglio wrote: > > If a 4k disk is used for first BIOS disk loader corrupt itself. > > This patch increase sector buffer in order to avoid this overflow > > Signed-off-by: Frediano Ziglio > --- > xen/arch/x86/boot/edd.S | 2 +- > xen/arch/x86/boot/trampoline.S | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/boot/edd.S b/xen/arch/x86/boot/edd.S > index 2c8df8c..1c802a6 100644 > --- a/xen/arch/x86/boot/edd.S > +++ b/xen/arch/x86/boot/edd.S > @@ -154,4 +154,4 @@ boot_mbr_signature_nr: > boot_mbr_signature: > .fill EDD_MBR_SIG_MAX*8,1,0 > boot_edd_info: > - .fill 512,1,0 # big enough for a disc sector > + .fill 4096,1,0 # big enough for a disc sector Can we get a #define for this value? > diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S > index 4421fc2..bd54c9e 100644 > --- a/xen/arch/x86/boot/trampoline.S > +++ b/xen/arch/x86/boot/trampoline.S > @@ -224,6 +224,6 @@ skip_realmode: > rm_idt: .word 256*4-1, 0, 0 > > #include "mem.S" > -#include "edd.S" > #include "video.S" > #include "wakeup.S" > +#include "edd.S" This part looks unnecessary. Included by mistake? David