From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxMBD-0005YX-KG for qemu-devel@nongnu.org; Fri, 03 Aug 2012 14:00:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxMBC-0001EE-Hh for qemu-devel@nongnu.org; Fri, 03 Aug 2012 14:00:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53093 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxMBC-0001E7-BD for qemu-devel@nongnu.org; Fri, 03 Aug 2012 14:00:54 -0400 Message-ID: <501C11CF.3050907@suse.de> Date: Fri, 03 Aug 2012 20:00:47 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1343962122-26696-1-git-send-email-akong@redhat.com> <1343962122-26696-6-git-send-email-akong@redhat.com> <20120803103233.2f48d5d1@doriath.home> In-Reply-To: <20120803103233.2f48d5d1@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the key_defs table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, Amos Kong , eblake@redhat.com, qemu-devel@nongnu.org Am 03.08.2012 15:32, schrieb Luiz Capitulino: > On Fri, 3 Aug 2012 10:48:40 +0800 > Amos Kong wrote: >=20 >> key_defs[] in monitor.c is a mapping table of keys and keycodes, >> this patch added a QKeyCode enum and a new key_defs table, >> Key's index in the enmu is same as keycode's index in new key_defs[]. >> >> Signed-off-by: Amos Kong >> --- >> input.c | 146 +++++++++++++++++++++++++++++++++++++++++++++= +++++++++ >> qapi-schema.json | 26 ++++++++++ >> 2 files changed, 172 insertions(+), 0 deletions(-) >> >> diff --git a/input.c b/input.c >> index 6968b31..680d756 100644 >> --- a/input.c >> +++ b/input.c >> @@ -37,6 +37,152 @@ static QTAILQ_HEAD(, QEMUPutMouseEntry) mouse_hand= lers =3D >> static NotifierList mouse_mode_notifiers =3D=20 >> NOTIFIER_LIST_INITIALIZER(mouse_mode_notifiers); >> =20 >> +static const int key_defs[] =3D { >=20 > Weird, I expected this would brake the build, as the new table is unuse= d. That's a side effect of 'const'. /-F --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg