Re: oops in pci_acs_path_enabled

[David Ahern <dsahern@gmail.com>]

On 8/3/12 3:52 PM, Alex Williamson wrote:
> Is this the chunk that's causing the oops?

Yes. And taking it out fixes passthrough as well.

David


>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 7469b53..27d8c97 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4133,6 +4133,7 @@ static int intel_iommu_add_device(struct device *dev)
>                                            PCI_DEVFN(PCI_SLOT(dma_pdev->devfn),
>                                            0)));
>
> +#if 0
>          while (!pci_is_root_bus(dma_pdev->bus)) {
>                  if (pci_acs_path_enabled(dma_pdev->bus->self,
>                                           NULL, REQ_ACS_FLAGS))
> @@ -4140,6 +4141,7 @@ static int intel_iommu_add_device(struct device *dev)
>
>                  swap_pci_ref(&dma_pdev, pci_dev_get(dma_pdev->bus->self));
>          }
> +#endif
>
>          group = iommu_group_get(&dma_pdev->dev);
>          pci_dev_put(dma_pdev);
>
>