All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Janusz Białobrzewski" <jbialobr@o2.pl>
To: Junio C Hamano <gitster@pobox.com>
Cc: msysgit@googlegroups.com, git@vger.kernel.org
Subject: Re: File path not escaped in warning message
Date: Sun, 05 Aug 2012 14:05:02 +0200	[thread overview]
Message-ID: <501E616E.6000907@o2.pl> (raw)
In-Reply-To: <7v39429u58.fsf@alter.siamese.dyndns.org>

Here is output from linux:

[janusz@mikrus JavaCommon]$ git config --add core.quotepath false
[janusz@mikrus JavaCommon]$ git diff  --unified=3 -- "1ą.txt"
warning: LF will be replaced by CRLF in 1<B1>.txt.
The file will have its original line endings in your working directory.
diff --git a/1<B1>.txt b/1<B1>.txt
index 281ad6f..9444a66 100644
--- a/1<B1>.txt
+++ b/1<B1>.txt
@@ -1,2 +1,2 @@
 aaaa
-bbb
+bbbc


[janusz@mikrus JavaCommon]$ git config --unset core.quotepath
[janusz@mikrus JavaCommon]$ git config --add core.quotepath true
[janusz@mikrus JavaCommon]$ git diff  --unified=3 -- "1ą.txt"
warning: LF will be replaced by CRLF in 1<B1>.txt.
The file will have its original line endings in your working directory.
diff --git "a/1\261.txt" "b/1\261.txt"
index 281ad6f..9444a66 100644
--- "a/1\261.txt"
+++ "b/1\261.txt"
@@ -1,2 +1,2 @@
 aaaa
-bbb
+bbbc

Janusz Białobrzewski.

Junio C Hamano pisze:
> Janusz Białobrzewski <jbialobr@o2.pl> writes:
>
>   
>> I have enabled core.quotepath, but file path in warning isn't escaped:
>> File name is 1ą.txt its content is encoded in windows-1250
>> Output of git diff after reencoding to windows1250 is:
>>
>> warning: LF will be replaced by CRLF in 1Ä….txt.
>> The file will have its original line endings in your working directory.
>>
>> But I expected it to be:
>>
>> warning: LF will be replaced by CRLF in 1\304\205.txt.
>> The file will have its original line endings in your working directory.
>>     
>
> Do msysgit folks want to look into this, perhaps?
>
> Thanks.
>
>   

  reply	other threads:[~2012-08-05 12:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-04 12:55 File path not escaped in warning message Janusz Białobrzewski
2012-08-04 22:20 ` Junio C Hamano
2012-08-05 12:05   ` Janusz Białobrzewski [this message]
2012-08-05 19:48     ` Junio C Hamano
2012-08-06  6:53       ` jbialobr
2012-08-06 17:18         ` karsten.blees
2012-08-07  8:20           ` jbialobr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501E616E.6000907@o2.pl \
    --to=jbialobr@o2.pl \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.