From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Sy23j-0000Mz-Ey for mharc-grub-devel@gnu.org; Sun, 05 Aug 2012 10:43:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sy23g-0000Kw-5L for grub-devel@gnu.org; Sun, 05 Aug 2012 10:43:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sy23f-0003Dj-4d for grub-devel@gnu.org; Sun, 05 Aug 2012 10:43:56 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:37253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sy23e-0003Dc-US for grub-devel@gnu.org; Sun, 05 Aug 2012 10:43:55 -0400 Received: by wgbds1 with SMTP id ds1so797540wgb.0 for ; Sun, 05 Aug 2012 07:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=rAvVN0Of1Afaf/U5Db9zb8JMMD06eK7OIA67SRqm9Ps=; b=Pbz7WpLkZTKHgRsMp+9BU7BArKJbR0zTExkFqv+IwXEsfXcMsbQ7IbQhGmK3mpnCFe 1lpCNGivu7B/aJztNFR4vznRREHX2ZEpfJmD59Eu5rKdEWbDF4BHqNGv3s9c2KyfBvk4 tgBWPp3l4GRMHb5CuiwlcurZaG5tH4M4UYD3hHxiDWHbH87gHrpxZGpq9ZkpKC+ciFlJ GNA2nKE4qsnIGOtD42nqBMfyYaZRt+6jZQVp3OgtxAamkCBhrRY6QUdiK5YaYygPAm7R k0UDi8+3PK51pUwRmbMwp5YArfCZC2/0erTX4bGwT/WfjrxKDhlyV9kvYMrKLbhefsql rFBw== Received: by 10.180.106.137 with SMTP id gu9mr11148777wib.20.1344177833533; Sun, 05 Aug 2012 07:43:53 -0700 (PDT) Received: from [192.168.1.37] (c2433-1-88-160-112-182.fbx.proxad.net. [88.160.112.182]) by mx.google.com with ESMTPS id fu8sm10001577wib.5.2012.08.05.07.43.52 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Aug 2012 07:43:53 -0700 (PDT) Message-ID: <501E86A8.6090105@gmail.com> Date: Sun, 05 Aug 2012 16:43:52 +0200 From: =?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Add gnulib's stpcpy. References: <501869BE.1010909@gmail.com> <501E44B4.1090900@gmail.com> In-Reply-To: <501E44B4.1090900@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2012 14:43:57 -0000 On 08/05/2012 12:02 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 01.08.2012 01:26, Grégoire Sutre wrote: > >> The attached patch adds gnulib's stpcpy. This is required >> on systems lacking stpcpy, e.g., NetBSD 5.1. >> > > Where do we need it? It may make more sense to just use grub_stpcpy in > these places. Calls to a stpcpy appear a couple times in: - util/grub-fstest.c - util/grub-probe.c - util/getroot.c [__linux__] I agree that using grub_stpcpy is fine there. The benefit of importing gnulib's stpcpy is that it solves current calls to stpcpy, as well as the future ones (that might be added to GRUB). There are also calls to stpcpy in: - grub-core/lib/libgcrypt/cipher/pubkey.c - grub-core/lib/libgcrypt/cipher/dsa.c but they do not cause any problem (these files are not compiled afaics). Grégoire