From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: dmitry.torokhov@gmail.com, shawn.guo@linaro.org,
kernel@pengutronix.de, aletes.xgr@gmail.com,
rob.herring@calxeda.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: gpio_keys - fix NULL pointer dereference for dt case
Date: Mon, 06 Aug 2012 14:20:27 +0530 [thread overview]
Message-ID: <501F8553.40902@ti.com> (raw)
In-Reply-To: <1344001314-2250-1-git-send-email-fabio.estevam@freescale.com>
On Friday 03 August 2012 07:11 PM, Fabio Estevam wrote:
> Commit 30161f6b2e7d1 (Input: gpio_keys - clean up device tree parser)
> introduced the following kernel crash for a dt based kernel:
> ..
> Unable to handle kernel NULL pointer dereference at virtual address 00000004
> pgd = 80004000
> [00000004] *pgd=00000000
> Internal error: Oops: 805 [#1] ARM
> Modules linked in:
> CPU: 0 Not tainted (3.5.0-next-20120802+ #1366)
> PC is at gpio_keys_probe+0x154/0x8c0
> LR is at of_gpiochip_find_and_xlate+0x54/0x70
> pc : [<803ddbac>] lr : [<801ed2f4>] psr: 60000013
> sp : 9f851df8 ip : 00000002 fp : 9f851e5c
> r10: 9f873d00 r9 : 00000001 r8 : 9fa2f900
> r7 : 809c0920 r6 : 9f873d08 r5 : 00000000 r4 : 809c09d4
> r3 : 805af10c r2 : 000000c0 r1 : 9f851db4 r0 : 000000d5
> Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
> Control: 10c5387d Table: 90004019 DAC: 00000015
> Process swapper (pid: 1, stack limit = 0x9f8502e8)
> Stack: (0x9f851df8 to 0x9f852000)
> ....
>
> The reason for the crash was due to 'button = &pdata->buttons[i++];'
> returning a NULL pointer, and then 'button' was accessed afterwards
> without checking for NULL.
>
> Fix this by correctly assigning 'pdata->buttons' and also add a NULL
> pointer check for 'button' pointer.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
>
Should we cc stable?
next prev parent reply other threads:[~2012-08-06 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 13:41 [PATCH] Input: gpio_keys - fix NULL pointer dereference for dt case Fabio Estevam
2012-08-06 8:50 ` Shubhrajyoti [this message]
2012-08-06 8:20 ` Dmitry Torokhov
2012-08-06 17:39 ` Datta, Shubhrajyoti
2012-08-17 0:01 ` Estevam Fabio-R49496
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501F8553.40902@ti.com \
--to=shubhrajyoti@ti.com \
--cc=aletes.xgr@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.