Re: [PATCH 0/5] Convert az6007 to dvb-usb-v2

[Antti Palosaari <crope@iki.fi>]

On 08/05/2012 06:30 AM, Mauro Carvalho Chehab wrote:
> Now that dvb-usb-v2 patches got merged, convert az6007 to use it, as,
> in thesis, several core bugs at dvb-usb were fixed.
>
> Also, driver became a little more simple than before, as the number of
> lines reduced a little bit.
>
> No noticeable changes should be noticed... I hope ;)
>
> Mauro Carvalho Chehab (5):
>    [media] dvb-usb-v2: Fix cypress firmware compilation
>    [media] dvb-usb-v2: Don't ask user to select Cypress firmware module
>    [media] az6007: convert it to use dvb-usb-v2
>    [media] az6007: fix the I2C W+R logic
>    [media] az6007: Fix the number of parameters for QAM setup
>
>   drivers/media/dvb/dvb-usb-v2/Kconfig               |  17 +-
>   drivers/media/dvb/dvb-usb-v2/Makefile              |   6 +-
>   drivers/media/dvb/{dvb-usb => dvb-usb-v2}/az6007.c | 385 +++++++++------------
>   drivers/media/dvb/dvb-usb/Kconfig                  |   8 -
>   drivers/media/dvb/dvb-usb/Makefile                 |   3 -
>   5 files changed, 178 insertions(+), 241 deletions(-)
>   rename drivers/media/dvb/{dvb-usb => dvb-usb-v2}/az6007.c (64%)
>

Whole patch set looks correct for my eyes.
Feel free to add tag(s) if you wish to those you want.
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>

One comment still about those log writings. Documentation says it should 
be used dev_* logging instead of pr_* in case of device driver. But I 
don't see that error should be fixed when that kind of conversion is done.


regards
Antti

-- 
http://palosaari.fi/