All of lore.kernel.org
 help / color / mirror / Atom feed
From: dirk.behme@de.bosch.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] gpio/mxc: remove redundant shadow variables initialization
Date: Mon, 6 Aug 2012 13:38:42 +0200	[thread overview]
Message-ID: <501FACC2.4010008@de.bosch.com> (raw)
In-Reply-To: <1344146488-9496-1-git-send-email-shawn.guo@linaro.org>

On 05.08.2012 08:01, Shawn Guo wrote:
> With commit 3e11f7b (gpio/generic: initialize basic_mmio_gpio shadow
> variables properly) in place, the shadow variables initialization is
> being done in generic driver bgpio_init call.
> 
> Remove the redundant shadow variables initialization from gpio-mxc
> driver.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Whole series:

Tested-by: Dirk Behme <dirk.behme@de.bosch.com>

Looks good :)

Many thanks

Dirk

> ---
>  drivers/gpio/gpio-mxc.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 4db460b..76e8cda 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -466,8 +466,6 @@ static int __devinit mxc_gpio_probe(struct platform_device *pdev)
>  
>  	port->bgc.gc.to_irq = mxc_gpio_to_irq;
>  	port->bgc.gc.base = pdev->id * 32;
> -	port->bgc.dir = port->bgc.read_reg(port->bgc.reg_dir);
> -	port->bgc.data = port->bgc.read_reg(port->bgc.reg_set);
>  
>  	err = gpiochip_add(&port->bgc.gc);
>  	if (err)

      parent reply	other threads:[~2012-08-06 11:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05  6:01 [PATCH 1/4] gpio/mxc: remove redundant shadow variables initialization Shawn Guo
2012-08-05  6:01 ` [PATCH 2/4] gpio/mxc: specify gpio base for device tree probe Shawn Guo
2012-08-05  9:47   ` Linus Walleij
2012-08-06 14:12   ` Uwe Kleine-König
2012-08-05  6:01 ` [PATCH 3/4] gpio/mxs: " Shawn Guo
2012-08-05  9:48   ` Linus Walleij
2012-08-06 13:51     ` Shawn Guo
2012-08-07  6:56       ` Linus Walleij
2012-08-05  6:01 ` [PATCH 4/4] ARM: dts: imx: add alias for gpio Shawn Guo
2012-08-05  9:49   ` Linus Walleij
2012-08-05  9:45 ` [PATCH 1/4] gpio/mxc: remove redundant shadow variables initialization Linus Walleij
2012-08-06 11:38 ` Dirk Behme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501FACC2.4010008@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.