From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyMXC-0003XG-PA for qemu-devel@nongnu.org; Mon, 06 Aug 2012 08:35:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyMX8-0004tf-G0 for qemu-devel@nongnu.org; Mon, 06 Aug 2012 08:35:46 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyMX8-0004qJ-9l for qemu-devel@nongnu.org; Mon, 06 Aug 2012 08:35:42 -0400 Received: from eusync3.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8C000FY30HGR50@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 06 Aug 2012 13:36:17 +0100 (BST) Received: from [106.109.9.232] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M8C00CVA2ZEWG20@eusync3.samsung.com> for qemu-devel@nongnu.org; Mon, 06 Aug 2012 13:35:39 +0100 (BST) Message-id: <501FBA1A.4040307@samsung.com> Date: Mon, 06 Aug 2012 16:35:38 +0400 From: Igor Mitsyanko MIME-version: 1.0 References: In-reply-to: Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Peter A. G. Crosthwaite" Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, edgar.iglesias@gmail.com, m.kozlov@samsung.com, john.williams@petalogix.com Recently I've noticed that drive_get_next() usage is not very convenient if you want to use specific SD controller interface. Maybe we should switch from drive_get_next() to DEFINE_PROP_DRIVE()? It'll still preserve "-sd .." behaviour. What do you think Peter?