All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH master/stable] virtio-mlk: fix use-after-free while handling scsi commands
Date: Mon, 06 Aug 2012 16:14:27 +0300	[thread overview]
Message-ID: <501FC333.1020309@redhat.com> (raw)
In-Reply-To: <CAJSP0QXZQuAoeED6tk65bUW9ETvP=aKkqK7_1DDGs=Z_HgH72Q@mail.gmail.com>

On 08/06/2012 04:11 PM, Stefan Hajnoczi wrote:
> On Mon, Aug 6, 2012 at 1:49 PM, Avi Kivity <avi@redhat.com> wrote:
>> The scsi passthrough handler falls through after completing a
>> request into the failure path, resulting in a use after free.
>>
>> Reprducible by running a guest with aio=native on a block device.
>>
>> Reported-by: Stefan Priebe <s.priebe@profihost.ag>
>> Signed-off-by: Avi Kivity <avi@redhat.com>
>> ---
>>  hw/virtio-blk.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> It would be nice to fix up the commit message:
> s/virtio-mlk/virtio-blk/

Sorry, an off-by-two.  Presumably Kevin will fix it up.

> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> 

Thanks.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-08-06 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 12:49 [Qemu-devel] [PATCH master/stable] virtio-mlk: fix use-after-free while handling scsi commands Avi Kivity
2012-08-06 13:11 ` Stefan Hajnoczi
2012-08-06 13:14   ` Avi Kivity [this message]
2012-08-06 14:21   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501FC333.1020309@redhat.com \
    --to=avi@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.