Re: [PATCH 2/4] rpc.gssd: don't call printerr from signal handler

[Steve Dickson <SteveD@redhat.com>]

On 07/31/2012 05:00 PM, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> printerr() isn't actually safe to call from a signal handler.  It might
> be possible to make it so, but I think this is the only case in
> nfs-utils where we try to, and I'm not convince it's worth it.
> 
> This fixes a bug that would eventually cause mounts to hang when gssd
> is run with -vv.
> 
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Committed...

steved.
> ---
>  utils/gssd/gssd_main_loop.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/utils/gssd/gssd_main_loop.c b/utils/gssd/gssd_main_loop.c
> index 9954ffb..6914687 100644
> --- a/utils/gssd/gssd_main_loop.c
> +++ b/utils/gssd/gssd_main_loop.c
> @@ -61,10 +61,8 @@ extern int pollsize;
>  
>  static volatile int dir_changed = 1;
>  
> -static void dir_notify_handler(int sig)
> +static void dir_notify_handler(__attribute__((unused))int sig)
>  {
> -	printerr(2, "dir_notify_handler: sig %d\n", sig);
> -
>  	dir_changed = 1;
>  }
>