From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH] drm/radeon: fence virtual address and free it once idle v3 Date: Mon, 06 Aug 2012 18:55:09 +0200 Message-ID: <501FF6ED.90605@vodafone.de> References: <1344029208-10069-1-git-send-email-j.glisse@gmail.com> <501CE652.7080509@vodafone.de> <501FEB68.5030605@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 675CF9E872 for ; Mon, 6 Aug 2012 09:55:12 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jerome Glisse Cc: Jerome Glisse , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 06.08.2012 18:30, Jerome Glisse wrote: > On Mon, Aug 6, 2012 at 12:06 PM, Christian K=F6nig > wrote: >> [SNIP] >> Additional to that patch we still need a minor fix to mesa (just move >> freeing the VM range after closing the handle). Going to send that in the >> next minute to the mesa-dev list. >> >> Otherwise the patch indeed fixes the problem, but also isn't the best id= ea >> for performance. >> >> Cheers, >> Christian. >> > This does not impact performance, it's all about destroying bo/va so > it's not a performance path. Or am i missing something here ? radeonsi currently allocates very small BOs (8-32 bytes) for T# = descriptors, and throws them away immediately after drawing. That alone of course is insane under a performance aspect, but waiting = for the last job to finish makes things completely worse. It just moves my priorities of hacking on radeonsi a bit around. Christian.