From: John Stultz <john.stultz@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
tglx@linutronix.de, a.p.zijlstra@chello.nl,
richardcochran@gmail.com, prarit@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] time: Fix adjustment cleanup bug in timekeeping_adjust()
Date: Mon, 06 Aug 2012 10:21:39 -0700 [thread overview]
Message-ID: <501FFD23.9080109@linaro.org> (raw)
In-Reply-To: <20120804192114.GA28347@gmail.com>
On 08/04/2012 12:21 PM, Ingo Molnar wrote:
> * Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
>
>> Hello.
>>
>> Bisected to 2a8c0883 "time: Move xtime_nsec adjustment
>> underflow handling timekeeping_adjust".
>>
>> Would you check?
> probably caused by this stray return in timekeeping_adjust():
>
> } else
> return;
>
> which should really be a proper goto - like the (totally
> untested!) patch below.
Ooof. Your analysis looks correct, thanks for fixing this, Ingo!
And thanks for catching the issue Tetsuo!
thanks
-john
prev parent reply other threads:[~2012-08-06 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:18 [3.6-rc1] sched: clock counts too quickly Tetsuo Handa
2012-08-04 11:24 ` Tetsuo Handa
2012-08-04 12:10 ` Tetsuo Handa
2012-08-04 13:46 ` Tetsuo Handa
2012-08-04 19:21 ` [PATCH] time: Fix adjustment cleanup bug in timekeeping_adjust() Ingo Molnar
2012-08-05 0:50 ` Tetsuo Handa
2012-08-05 17:00 ` [tip:timers/urgent] " tip-bot for Ingo Molnar
2012-08-06 17:21 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501FFD23.9080109@linaro.org \
--to=john.stultz@linaro.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.