All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 11/30] lsb: use ${base_bindir} instead of /bin for packaging
Date: Mon, 6 Aug 2012 12:29:04 -0500	[thread overview]
Message-ID: <501FFEE0.5060503@windriver.com> (raw)
In-Reply-To: <1344182057-15981-12-git-send-email-javier@dowhile0.org>

On 8/5/12 10:53 AM, Javier Martinez Canillas wrote:
> It is considered good practice to use the build system provided
> variables instead of directly specify hardcoded paths.
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
>   meta/recipes-extended/lsb/lsb_1.4.bb |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-extended/lsb/lsb_1.4.bb b/meta/recipes-extended/lsb/lsb_1.4.bb
> index 15dbeaa..5734c5c 100644
> --- a/meta/recipes-extended/lsb/lsb_1.4.bb
> +++ b/meta/recipes-extended/lsb/lsb_1.4.bb
> @@ -23,7 +23,7 @@ S = "${WORKDIR}/lsb-release-${PV}"
>
>   do_install(){
>   	oe_runmake install prefix=${D}  mandir=${D}/${datadir}/man/ DESTDIR=${D}
> -	mkdir -p ${D}/bin
> +	mkdir -p ${D}${base_bindir}
>   	mkdir -p ${D}/${baselib}
>   	mkdir -p ${D}/etc/lsb-release.d
>   	echo -n "LSB_VERSION=\"core-4.1-noarch:" > ${D}/etc/lsb-release
>

This is another case with the lsb, that lsb-release (and a few other things) are 
documented to me installed into /bin.

Not objecting to the change, just explaining why it was implemented this way.

--Mark



  reply	other threads:[~2012-08-06 17:40 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05 15:53 [PATCH 00/30] cleanup: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 01/30] xinetd: use ${sbindir} instead of /usr/sbin for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 02/30] alsa-state: " Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 03/30] lsbsetup: use ${bindir} instead of /usr/bin " Javier Martinez Canillas
2012-08-06 17:25   ` Mark Hatle
2012-08-05 15:53 ` [PATCH 04/30] sudo: use ${bindir} and ${sysconfdir} instead of /usr/bin and /etc Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 05/30] lsbtest: use ${bindir} instead of /usr/bin for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 06/30] cronie: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 07/30] useradd-example: use ${datadir} instead of /usr/share for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 08/30] ubootchart: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 09/30] xkeyboard-config: use ${datadir} instead of /usr/share for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 10/30] systemtap: " Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 11/30] lsb: use ${base_bindir} instead of /bin " Javier Martinez Canillas
2012-08-06 17:29   ` Mark Hatle [this message]
2012-08-05 15:53 ` [PATCH 12/30] mingetty: use ${base_sbindir} instead of /sbin " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 13/30] external-sourcery: use ${prefix} and ${libdir} instead of /usr and /usr/lib Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 14/30] rpm: use ${localstatedir} and ${libdir} instead of /var " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 15/30] at: use ${base_sbindir} instead of /sbin for packaging Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 16/30] kernel.bbclass: use ${base_libdir} and ${sysconfdir} instead of /lib and /etc Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 17/30] linux-firware: use ${base_libdir} instead of /lib for packaging Javier Martinez Canillas
2012-08-06 18:10   ` Darren Hart
2012-08-06 18:21     ` Phil Blundell
2012-08-07 16:14       ` Darren Hart
2012-08-07 18:29         ` Koen Kooi
2012-08-05 15:54 ` [PATCH 18/30] openssh: use ${localstatedir} instead of /var " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 19/30] libpam: use ${localstatedir} and ${sysconfdir} instead of /var and /etc Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 20/30] x11-common: use ${sysconfdir} instead of /etc for packaging Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 21/30] lsb: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 22/30] builder: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 23/30] xserver-nodm-init: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 24/30] lsbinitscripts: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 25/30] xinetd: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 26/30] usbinit: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 27/30] qemu-config: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 28/30] rsync: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 29/30] chkconfig: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 30/30] man: " Javier Martinez Canillas
2012-08-05 18:16 ` [PATCH 00/30] cleanup: use variables instead of hardcoded paths Otavio Salvador
2012-08-05 19:10   ` Khem Raj
2012-08-05 19:19     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501FFEE0.5060503@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.