From: You-Sheng Yang <vicamo@gmail.com>
To: AceLan Kao <acelan.kao@canonical.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
Enrico Weigelt <info@metux.net>,
Stephen Boyd <swboyd@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: i8042 - Fix the selftest retry logic
Date: Tue, 10 Mar 2020 11:35:02 +0800 [thread overview]
Message-ID: <501e8224-e334-0aa8-41c0-8f67552e7069@gmail.com> (raw)
In-Reply-To: <20200305064423.16196-1-acelan.kao@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 561 bytes --]
On 2020-03-05 14:44, AceLan Kao wrote:
> @@ -955,7 +954,9 @@ static int i8042_controller_selftest(void)
> dbg("i8042 controller selftest: %#x != %#x\n",
> param, I8042_RET_CTL_TEST);
> msleep(50);
> - } while (i++ < 5);
> + } while (++i < 5);
> + if (i == 5)
> + return -ENODEV;
I would like to propose a V2 for this. The original logic allows
continuation to device probe when selftest returns a different value
than expected, and this is no longer available with this patch.
> #ifdef CONFIG_X86
> /*
>
You-Sheng Yang
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-10 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 6:44 [PATCH] Input: i8042 - Fix the selftest retry logic AceLan Kao
2020-03-06 4:16 ` Dmitry Torokhov
2020-03-06 6:40 ` AceLan Kao
2020-03-10 3:35 ` You-Sheng Yang [this message]
2020-03-10 3:36 ` [PATCH v2] Input: i8042 - fix " You-Sheng Yang
2020-03-17 4:22 ` AceLan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501e8224-e334-0aa8-41c0-8f67552e7069@gmail.com \
--to=vicamo@gmail.com \
--cc=acelan.kao@canonical.com \
--cc=allison@lohutok.net \
--cc=dmitry.torokhov@gmail.com \
--cc=info@metux.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.