All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>,
	linux-kernel@vger.kernel.org,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Gyungoh Yoo <jack.yoo@maxim-ic.com>,
	Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] regulator: add MAX8907 driver
Date: Mon, 06 Aug 2012 15:22:17 -0600	[thread overview]
Message-ID: <50203589.5020509@wwwdotorg.org> (raw)
In-Reply-To: <20120804101918.GD9248@opensource.wolfsonmicro.com>

On 08/04/2012 04:19 AM, Mark Brown wrote:
> On Thu, Aug 02, 2012 at 12:27:13PM -0600, Stephen Warren wrote:
> 
>> The MAX8907 is an I2C-based power-management IC containing voltage
>> regulators, a reset controller, a real-time clock, and a touch-screen
>> controller.

>> +static int max8907_regulator_wled_set_current_limit(struct regulator_dev *rdev,
>> +						    int min_uA, int max_uA)
> 
> I'm really not convinced it makes much sense to represent the backlight
> driver current regulators as regulators, they only get used as part of
> the backlight and are usually tightly coupled to their boosts.

So you mean just completely remove any reference to WLED from the
driver? There is a register to configure the current limit - do you not
expect anything to ever need to set that in the kernel; do you expect
the HW default to be correct, or the bootloader to set the desired value?

Thanks for the other parts of the review.

  reply	other threads:[~2012-08-06 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 18:27 [PATCH] regulator: add MAX8907 driver Stephen Warren
2012-08-04 10:19 ` Mark Brown
2012-08-06 21:22   ` Stephen Warren [this message]
2012-08-06 21:47     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50203589.5020509@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jack.yoo@maxim-ic.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.