Re: [denzil branch] Update to the latest version of psplash

[Scott Garman <scott.a.garman@intel.com>]

On 08/06/2012 02:43 PM, Cooper Jr., Franklin wrote:
> In the latest version of psplash
> (http://git.yoctoproject.org/cgit/cgit.cgi/psplash/)  there are two
> patches that are not in the version of psplash used in the oe-core
> denzil branch. The first patch called Make it easier to customise
> colours
> <http://git.yoctoproject.org/cgit/cgit.cgi/psplash/commit/?id=84764337a584002a92940323d374b0e417c573a6>moves
> some color definitions from being hardcoded into psplash.c and puts it
> in a new header file called psplash-colors.h.  The second patch Fix for
> psplash segmentation fault
> <http://git.yoctoproject.org/cgit/cgit.cgi/psplash/commit/?id=de9979aefbc56af59b4d236a4b63dd19dcdcfb53>fixes
> a segment fault issue.
>
> What I would like to do is update the psplash_git.bb recipe to use the
> latest version of psplash that pulls in these two tweaks. The second
> patch has zero impact on existing users of the pslash recipe. If a
> particular layer tweaks the color definitions in psplash by patching the
> psplash.c file then the second patch mentioned above could result in a
> minor tweak having to be made to those layers to address the changes. In
> oe-classic noticed that there is a patch for psplash
> (http://cgit.openembedded.org/openembedded/tree/recipes/psplash/psplash-ti/0001-configurability-for-rev-422.patch)
> that patches psplash in almost the same exact way as the “Make it easier
> to customize colours” patch.
>
> Are there any objections in bumping the version of psplash to
> incorporate the above mentioned patches? I haven’t seen any layer adjust
> the psplash color definitions so I doubt there truly being any impact at
> all.**

Franklin and I discussed this on IRC and I suggested he bring this up on 
the mailing list.

I'm inclined to take and backport the segfault patch into the current 
version of psplash in denzil (which is a git recipe fixed at e05374a). 
Bumping the SRCREV of the recipe and including the color definitions 
patch I'm not so sure about - vocal support from the community could tip 
the scales, though, so speak up if this would be of value to you.

The segfault patch is being tracked with bug #2903:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=2903

Thanks,

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center