From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended Date: Tue, 7 Aug 2012 14:18:11 +0800 Message-ID: <5020B323.4010102@amd.com> References: <1343379650-2867-1-git-send-email-aaron.lu@amd.com> <1343379650-2867-5-git-send-email-aaron.lu@amd.com> <501B9EE7.1080000@amd.com> <501BE5B2.5040901@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from db3ehsobe006.messaging.microsoft.com ([213.199.154.144]:24722 "EHLO db3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659Ab2HGGRr (ORCPT ); Tue, 7 Aug 2012 02:17:47 -0400 In-Reply-To: <501BE5B2.5040901@pobox.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Tejun Heo , Jens Axboe , James Bottomley , Alan Stern , Sergei Shtylyov , Oliver Neukum , Jeff Wu , Lin Ming , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Aaron Lu On 08/03/2012 10:52 PM, Jeff Garzik wrote: > On 08/03/2012 05:50 AM, Aaron Lu wrote: >> Hello, >> >> Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any >> comments? > > Typically you follow the pattern of similar exports in the file (or in > the API, if no others are in the file). Thanks Jeff for your suggestion, and I'll keep using EXPORT_SYMBOL. If anyone thinks this is wrong, please kindly let me know, thanks. -Aaron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762Ab2HGGRt (ORCPT ); Tue, 7 Aug 2012 02:17:49 -0400 Received: from db3ehsobe006.messaging.microsoft.com ([213.199.154.144]:24722 "EHLO db3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659Ab2HGGRr (ORCPT ); Tue, 7 Aug 2012 02:17:47 -0400 X-Forefront-Antispam-Report: CIP:163.181.249.108;KIP:(null);UIP:(null);IPV:NLI;H:ausb3twp01.amd.com;RD:none;EFVD:NLI X-SpamScore: -9 X-BigFish: VPS-9(zzbb2dI98dI9371Idf9M1432Izz1202hzzz2dh668h839hd25he5bhf0ah107ah) X-WSS-ID: 0M8DG5G-01-2ZL-02 X-M-MSG: Message-ID: <5020B323.4010102@amd.com> Date: Tue, 7 Aug 2012 14:18:11 +0800 From: Aaron Lu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Jeff Garzik CC: Tejun Heo , Jens Axboe , James Bottomley , Alan Stern , Sergei Shtylyov , Oliver Neukum , Jeff Wu , Lin Ming , , , , , Aaron Lu Subject: Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended References: <1343379650-2867-1-git-send-email-aaron.lu@amd.com> <1343379650-2867-5-git-send-email-aaron.lu@amd.com> <501B9EE7.1080000@amd.com> <501BE5B2.5040901@pobox.com> In-Reply-To: <501BE5B2.5040901@pobox.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 Aug 2012 06:17:13.0694 (UTC) FILETIME=[492E5FE0:01CD7464] X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2012 10:52 PM, Jeff Garzik wrote: > On 08/03/2012 05:50 AM, Aaron Lu wrote: >> Hello, >> >> Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any >> comments? > > Typically you follow the pattern of similar exports in the file (or in > the API, if no others are in the file). Thanks Jeff for your suggestion, and I'll keep using EXPORT_SYMBOL. If anyone thinks this is wrong, please kindly let me know, thanks. -Aaron