From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============5815636569882463871=="
MIME-Version: 1.0
From: Denis Kenzior <denkenz@gmail.com>
Subject: Re: [PATCH 3/4] service: Add DBus method to set delivery-report
Date: Tue, 07 Aug 2012 02:21:16 -0500
Message-ID: <5020C1EC.4040007@gmail.com>
In-Reply-To: <1344267060-5541-4-git-send-email-ronald.tessier@linux.intel.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============5815636569882463871==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Ronald,

On 08/06/2012 10:30 AM, Ronald Tessier wrote:
> ---
>   doc/service-api.txt |    6 ++++++
>   src/service.c       |   46 ++++++++++++++++++++++++++++++++++++++++++++=
++
>   2 files changed, 52 insertions(+)

Please separate this into two patches, one for api changes and one for =

code changes.

>
> diff --git a/doc/service-api.txt b/doc/service-api.txt
> index 02396ff..f247d3a 100644
> --- a/doc/service-api.txt
> +++ b/doc/service-api.txt
> @@ -82,6 +82,12 @@ Methods		array{object,dict} GetMessages()
>
>   			Possible Errors: [service].Error.InvalidArguments
>
> +		void SetProperty(string name, variant value)
> +
> +			Changes the value of the specified property.
> +
> +			Possible Errors: [service].Error.InvalidArguments
> +
>
>   Signals		MessageAdded(object path, dict properties)
>

You're missing the Property section additions and the description of the =

UseDeliveryReports property.

> diff --git a/src/service.c b/src/service.c
> index 7243efd..c1ca4ab 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -887,6 +887,48 @@ out:
>   	return reply;
>   }
>
> +static DBusMessage *set_property(DBusConnection *conn, DBusMessage *dbus=
_msg,
> +								void *data)
> +{
> +	struct mms_service *service =3D data;
> +	DBusMessageIter iter;
> +	DBusMessageIter var;
> +	const char *property;
> +
> +	if (!dbus_message_iter_init(dbus_msg,&iter))
> +		return __mms_error_invalid_args(dbus_msg);
> +
> +	if (dbus_message_iter_get_arg_type(&iter) !=3D DBUS_TYPE_STRING)
> +		return __mms_error_invalid_args(dbus_msg);
> +
> +	dbus_message_iter_get_basic(&iter,&property);
> +	dbus_message_iter_next(&iter);
> +
> +	if (dbus_message_iter_get_arg_type(&iter) !=3D DBUS_TYPE_VARIANT)
> +		return __mms_error_invalid_args(dbus_msg);
> +
> +	dbus_message_iter_recurse(&iter,&var);
> +
> +	if (!strcmp(property, "UseDeliveryReports")) {
> +		dbus_bool_t value;
> +
> +		if (dbus_message_iter_get_arg_type(&var) !=3D DBUS_TYPE_BOOLEAN)
> +			return __mms_error_invalid_args(dbus_msg);
> +
> +		dbus_message_iter_get_basic(&var,&value);
> +
> +		if (service->use_delivery_reports !=3D (gboolean) value) {
> +			DBG("use_delivery_reports =3D %d", value);
> +
> +			service->use_delivery_reports =3D value;
> +		}
> +
> +		return g_dbus_create_reply(dbus_msg, DBUS_TYPE_INVALID);
> +	}
> +
> +	return __mms_error_invalid_args(dbus_msg);
> +}
> +
>   static gboolean mms_attachment_is_smil(const struct mms_attachment *par=
t)
>   {
>   	if (g_str_has_prefix(part->content_type, "application/smil"))
> @@ -1023,6 +1065,10 @@ static const GDBusMethodTable service_methods[] =
=3D {
>   			GDBUS_ARGS({ "number", "s" }, { "count", "s" }),
>   			GDBUS_ARGS({ "messages_with_properties", "a(oa{sv}" }),
>   			get_conversation) },
> +	{ GDBUS_METHOD("SetProperty",
> +			GDBUS_ARGS({ "property", "s" }, { "value", "v" }),
> +		       NULL,
> +			set_property) },
>   	{ }
>   };
>

Regards,
-Denis

--===============5815636569882463871==--