Re: [PATCH 4/4] test: Add a script to set the delivery-report flag

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Hi Ronald,

On 08/06/2012 10:31 AM, Ronald Tessier wrote:
> ---
>   test/set-dr |   25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>   create mode 100755 test/set-dr
>

Add this to Makefile.am as well.

> diff --git a/test/set-dr b/test/set-dr
> new file mode 100755
> index 0000000..99c72b1
> --- /dev/null
> +++ b/test/set-dr
> @@ -0,0 +1,25 @@
> +#!/usr/bin/python
> +
> +import sys
> +import dbus
> +
> +bus = dbus.SessionBus()
> +
> +manager = dbus.Interface(bus.get_object('org.ofono.mms', '/org/ofono/mms'),
> +					'org.ofono.mms.Manager')
> +
> +services = manager.GetServices()
> +path = services[0][0]
> +
> +service = dbus.Interface(bus.get_object('org.ofono.mms', path),
> +						'org.ofono.mms.Service')
> +
> +if len(sys.argv)>  1:
> +	allowed = dbus.Boolean(int(sys.argv[1]))
> +else:
> +	allowed = dbus.Boolean(1)
> +
> +service.SetProperty("UseDeliveryReports", allowed)
> +
> +print "Setting delivery report use for %s...(UseDeliveryReports=%d)" %\
> +	(path, allowed)

Should this be printed prior to calling SetProperty?  Otherwise it 
should be 'Set' not 'Setting'.

Regards,
-Denis