Re: [PATCH 3.6-rc1] canfd: remove redundant CAN FD flag

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]

On 08/06/2012 06:02 PM, Oliver Hartkopp wrote:
> The first idea of the CAN FD implementation started with a new struct
> canfd_frame to be used for both CAN FD frames and legacy CAN frames.
> The now mainlined implementation supports both CAN frame types simultaneously
> and distinguishes them only by their required sizes: CAN_MTU and CANFD_MTU.
> 
> Only the struct canfd_frame contains a flags element which is needed for the
> additional CAN FD information. As CAN FD implicitly means that the 'Extened
> Data Length' mode is enabled the formerly defined CANFD_EDL bit became
> redundant and also confusing as an unset bit would be an error and would
> always need to be tested.
> 
> This patch removes the obsolete CANFD_EDL bit and clarifies the documentation
> for the use of struct canfd_frame and the CAN FD relevant flags.
> 
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> 
> ---
> 
> Hello Marc,
> 
> when thinking about the extension of the can-utils to support the handling of
> CAN FD specific flags in logfiles and console output i stumbled upon an
> implementation artifact i would like to fix before 3.6 is released.
> 
> The former flags definition turned out to be hard to use and is redundant in
> the case of the CANFD_EDL flag.
> 
> Do you want to take that patch in your linux-can tree to be pulled for 3.6-rc2
> or should i send it to Dave/netdev-ML directly?
> The patch is based on Linus' 3.6-rc1 tree.

I'll take the patch. As I'm the single point of contact, David will
probably refuse to take it directly from you. I hope no one will blame
us hard for modifying the ABI of the kernel for canfd frames. However I
think it's okay as there are probably no users of the canfd frame out there.

BTW: warning: 1 line adds whitespace errors.
I've fixed this.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]