From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SyjMD-0000EI-Kv
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:57:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SyjM9-00083y-Ji
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:57:57 -0400
Message-ID: <502110CA.7010102@suse.de>
Date: Tue, 07 Aug 2012 14:57:46 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1344307320-25094-2-git-send-email-zhlcindy@linux.vnet.ibm.com>
	<1344341985-10065-2-git-send-email-borntraeger@de.ibm.com>
In-Reply-To: <1344341985-10065-2-git-send-email-borntraeger@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC/PATCH 1/1] USB code fenced for s390
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-ppc@nongnu.org, aliguori@us.ibm.com, Peter Maydell <peter.maydell@linaro.org>, agraf@suse.de, Li Zhang <zhlcindy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Jens Freimann <jfrei@linux.vnet.ibm.com>, Li Zhang <zhlcindy@gmail.com>, Eugene Dvurechenski <jno@linux.vnet.ibm.com>, david@gibson.dropbear.id.au

Am 07.08.2012 14:19, schrieb Christian Borntraeger:
> From: Eugene Dvurechenski <jno@linux.vnet.ibm.com>
>=20
> on s390 there is no usb support and the -usb option doesnt
> do anything.
> This patch fences all usb code for s390.
>=20
> Signed-off-by: Eugene Dvurechenski <jno@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  configure        |   66 +++++++++++++++++++++++++++++++++++++++++-----=
-------
>  hmp-commands.hx  |    6 +++++
>  hw/Makefile.objs |    5 ++-
>  monitor.c        |    4 +++
>  qemu-options.hx  |    4 +++
>  sysemu.h         |    2 +
>  vl.c             |    8 +++++-
>  7 files changed, 76 insertions(+), 19 deletions(-)

This patch seems to be mixing two things:

1) Disabling USB host support. If System z mainframes don't have USB
support, it doesn't make much sense to enable USB host passthrough.

2) Disabling USB support for guest machines. Wasn't there a recent
virtio-usb RFC? In that case it would very well be possible to connect
virtual USB devices (including smartcard) to the virtio s390 machine.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg