From: Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH] netdev/phy: skip disabled mdio-mux nodes
Date: Tue, 7 Aug 2012 12:04:00 -0500 [thread overview]
Message-ID: <50214A80.4020305@freescale.com> (raw)
In-Reply-To: <5021496D.8070200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
David Daney wrote:
> Although this will get the job done, I don't think it is the cleanest
> approach.
>
> Would it be better to create a new iterator
> (for_each_available_child_of_node perhaps) that skips the unavailable
> nodes? This seems like a general problem that is not restricted to mdio
> multiplexers.
You're probably right, but this is how it's normally done. If you're
going to scan child nodes manually, you have to skip disabled nodes.
If someone else wants to implement for_each_available_child_of_node(), I'm
all for it, but such a patch would not be merged until 3.7. I was hoping
to have my patch applied to 3.6, since it fixes a real bug.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2012-08-07 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1344358266-5450-1-git-send-email-timur@freescale.com>
2012-08-07 16:59 ` [PATCH] netdev/phy: skip disabled mdio-mux nodes David Daney
[not found] ` <5021496D.8070200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-07 17:04 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50214A80.4020305@freescale.com \
--to=timur-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.