All of lore.kernel.org
 help / color / mirror / Atom feed
From: dwalsh@redhat.com (Daniel J Walsh)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH]: force a label on the fc_sort executable
Date: Tue, 07 Aug 2012 14:14:09 -0400	[thread overview]
Message-ID: <50215AF1.9010303@redhat.com> (raw)
In-Reply-To: <5021585F.2030401@trentalancia.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/07/2012 02:03 PM, Guido Trentalancia wrote:
> On 07/08/2012 19:46, Christopher J. PeBenito wrote:
>> On 08/04/12 21:06, Guido Trentalancia wrote:
>>> Force a bin_t label on the fc_sort executable after creating it, to
>>> avoid possible execution denials under certain conditions.
>>> 
>>> Signed-off-by: Guido Trentalancia <guido@trentalancia.com> --- Makefile
>>> |    1 + 1 file changed, 1 insertion(+)
>>> 
>>> --- refpolicy-04062012/Makefile	2012-05-29 21:13:09.413703575 +0200 +++
>>> refpolicy-04062012-chcon-fc_sort/Makefile	2012-08-04 21:35:57.396092798
>>> +0200 @@ -400,6 +400,7 @@ $(mod_conf) $(booleans): $(polxml) # 
>>> $(fcsort) : $(support)/fc_sort.c $(verbose) $(CC) $(CFLAGS) $^ -o $@ +
>>> chcon system_u:object_r:bin_t:s0 $(tmpdir)/fc_sort
>>> 
>>> ######################################## #
>> 
>> I'm not sure this actually is a good choice because this may be done on a
>> different system than where the policy will be deployed.  It may have a
>> different policy running or even SELinux disabled.
> 
> It doesn't matter whether the policy is deployed elsewhere (this is not 
> being discussed as the problem might be executing fc_sort for building the
> policy).
> 
> It's easy to check if SELinux is enabled (getenforce | grep -q Enforcing &&
> chcon system_u:object_r:bin_t:s0 $(tmpdir)/fc_sort). Or perhaps have it
> just failing silently.
> 
> Regards,
> 
> Guido
> 
> _______________________________________________ refpolicy mailing list 
> refpolicy at oss.tresys.com http://oss.tresys.com/mailman/listinfo/refpolicy
> 

selinuxenabeled && chcon  system_u:object_r:bin_t:s0 $(tmpdir)/fc_sort).

Would be better...

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlAhWvEACgkQrlYvE4MpobNV6wCgnvfHal4QCDHNGP5PNAWcP1kc
dDYAniSAUQhlNlqei2ULQ56kpW6WuC2o
=n0IB
-----END PGP SIGNATURE-----

  reply	other threads:[~2012-08-07 18:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05  1:06 [refpolicy] [PATCH]: force a label on the fc_sort executable Guido Trentalancia
2012-08-07 17:46 ` Christopher J. PeBenito
2012-08-07 18:03   ` Guido Trentalancia
2012-08-07 18:14     ` Daniel J Walsh [this message]
2012-08-15  7:27       ` Guido Trentalancia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50215AF1.9010303@redhat.com \
    --to=dwalsh@redhat.com \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.