All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
	git@vger.kernel.org, trast@student.ethz.ch, mhagger@alum.mit.edu,
	gitster@pobox.com
Subject: Re: [PATCH 2/2] Add index-v5
Date: Tue, 07 Aug 2012 23:52:22 +0200	[thread overview]
Message-ID: <50218E16.1010304@dewire.com> (raw)
In-Reply-To: <1344263760-31191-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy skrev 2012-08-06 16.36:

> +++ b/read-cache-v5.c
> @@ -0,0 +1,1170 @@
> +#include "cache.h"
> +#include "read-cache.h"
> +#include "resolve-undo.h"
> +#include "cache-tree.h"
> +
> +struct cache_header_v5 {
> +	unsigned int hdr_ndir;
> +	unsigned int hdr_nfile;
> +	unsigned int hdr_fblockoffset;
> +	unsigned int hdr_nextension;
> +};
> +
> +struct ondisk_cache_entry_v5 {
> +	unsigned short flags;
> +	unsigned short mode;
> +	struct cache_time mtime;
> +	int stat_crc;
> +	unsigned char sha1[20];
> +};

I mentioned this before in another thread, but for JGit I'd like
to see size as a separate attribute. The rest of stat_crc is not
available to Java so when this index gets its way into JGit,
stat_crc will be zero and will never be checked.

-- robin

  reply	other threads:[~2012-08-07 21:52 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05 21:48 [PATCH/RFC v2 0/16] Introduce index file format version 5 Thomas Gummerer
2012-08-05 21:48 ` [PATCH/RFC v2 01/16] Modify cache_header to prepare for other index formats Thomas Gummerer
2012-08-06  1:17   ` Junio C Hamano
2012-08-07 12:41     ` Thomas Gummerer
2012-08-07 15:45       ` Junio C Hamano
2012-08-05 21:48 ` [PATCH/RFC v2 02/16] Modify read functions " Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 03/16] Modify match_stat_basic " Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 04/16] Modify write functions " Thomas Gummerer
2012-08-06  1:34   ` Junio C Hamano
2012-08-07 12:50     ` Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 05/16] t2104: Don't fail for index versions other than [23] Thomas Gummerer
2012-08-06  1:36   ` Junio C Hamano
2012-08-05 21:49 ` [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code Thomas Gummerer
2012-08-06  1:43   ` Junio C Hamano
2012-08-07 16:59     ` Thomas Gummerer
2012-08-08 20:16       ` Junio C Hamano
2012-08-08 20:57         ` Junio C Hamano
2012-08-09 13:19           ` Thomas Gummerer
2012-08-09 16:51             ` Junio C Hamano
2012-08-09 22:51               ` Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 07/16] Add documentation of the index-v5 file format Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 08/16] Make in-memory format aware of stat_crc Thomas Gummerer
2012-08-06  1:46   ` Junio C Hamano
2012-08-07 19:02     ` Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 09/16] Read index-v5 Thomas Gummerer
2012-08-06  5:17   ` Junio C Hamano
2012-08-08  7:41     ` Thomas Gummerer
2012-08-08 16:49       ` Junio C Hamano
2012-08-08 20:44         ` Thomas Gummerer
2012-08-08 21:50           ` Junio C Hamano
2012-08-05 21:49 ` [PATCH/RFC v2 10/16] Read resolve-undo data Thomas Gummerer
2012-08-06  1:51   ` Junio C Hamano
2012-08-07 19:17     ` Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 11/16] Read cache-tree in index-v5 Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 12/16] Write index-v5 Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 13/16] Write index-v5 cache-tree data Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 14/16] Write resolve-undo data for index-v5 Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 15/16] update-index.c: add a force-rewrite option Thomas Gummerer
2012-08-06  1:58   ` Junio C Hamano
2012-08-08  7:31     ` Thomas Gummerer
2012-08-05 21:49 ` [PATCH/RFC v2 16/16] p0002-index.sh: add perf test for the index formats Thomas Gummerer
2012-08-06 14:35 ` [PATCH/RFC v2 0/16] Introduce index file format version 5 Nguyễn Thái Ngọc Duy
2012-08-06 14:35   ` [PATCH 1/2] Move index v2 specific code out of read-cache Nguyễn Thái Ngọc Duy
2012-08-06 14:36   ` [PATCH 2/2] Add index-v5 Nguyễn Thái Ngọc Duy
2012-08-07 21:52     ` Robin Rosenberg [this message]
2012-08-08 10:54       ` Thomas Gummerer
2012-08-06 15:51   ` [PATCH/RFC v2 0/16] Introduce index file format version 5 Junio C Hamano
2012-08-06 16:06     ` Thomas Gummerer
2012-08-06 17:46   ` Junio C Hamano
2012-08-07 12:16     ` Nguyen Thai Ngoc Duy
2012-08-08  1:38       ` Junio C Hamano
2012-08-08 13:54         ` Nguyen Thai Ngoc Duy
2012-08-08 16:31           ` Junio C Hamano
2012-08-09  2:28             ` Nguyen Thai Ngoc Duy
2012-08-07 22:31     ` Thomas Rast
2012-08-07 23:26       ` Junio C Hamano
2012-08-08  9:07         ` Thomas Rast
2012-08-08 22:47           ` Junio C Hamano
2012-08-08 10:30       ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50218E16.1010304@dewire.com \
    --to=robin.rosenberg@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    --cc=pclouds@gmail.com \
    --cc=t.gummerer@gmail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.