From: Antti Palosaari <crope@iki.fi>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 05/11] dvb: frontends: use %*ph to dump small buffers
Date: Wed, 08 Aug 2012 01:34:35 +0300 [thread overview]
Message-ID: <502197FB.7090500@iki.fi> (raw)
In-Reply-To: <1344357792-18202-5-git-send-email-andriy.shevchenko@linux.intel.com>
On 08/07/2012 07:43 PM, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Antti Palosaari <crope@iki.fi>
Acked-by: Antti Palosaari <crope@iki.fi>
Nice! I have been looking that kind of solution long time.
> ---
> drivers/media/dvb/frontends/cxd2820r_t.c | 3 +--
> drivers/media/dvb/frontends/nxt200x.c | 8 +++-----
> drivers/media/dvb/frontends/rtl2830.c | 2 +-
> 3 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/cxd2820r_t.c b/drivers/media/dvb/frontends/cxd2820r_t.c
> index 1a02623..e5dd22b 100644
> --- a/drivers/media/dvb/frontends/cxd2820r_t.c
> +++ b/drivers/media/dvb/frontends/cxd2820r_t.c
> @@ -389,8 +389,7 @@ int cxd2820r_read_status_t(struct dvb_frontend *fe, fe_status_t *status)
> }
> }
>
> - dbg("%s: lock=%02x %02x %02x %02x", __func__,
> - buf[0], buf[1], buf[2], buf[3]);
> + dbg("%s: lock=%*ph", __func__, 4, buf);
>
> return ret;
> error:
> diff --git a/drivers/media/dvb/frontends/nxt200x.c b/drivers/media/dvb/frontends/nxt200x.c
> index 03af52e..8e28894 100644
> --- a/drivers/media/dvb/frontends/nxt200x.c
> +++ b/drivers/media/dvb/frontends/nxt200x.c
> @@ -331,7 +331,7 @@ static int nxt200x_writetuner (struct nxt200x_state* state, u8* data)
>
> dprintk("%s\n", __func__);
>
> - dprintk("Tuner Bytes: %02X %02X %02X %02X\n", data[1], data[2], data[3], data[4]);
> + dprintk("Tuner Bytes: %*ph\n", 4, data + 1);
>
> /* if NXT2004, write directly to tuner. if NXT2002, write through NXT chip.
> * direct write is required for Philips TUV1236D and ALPS TDHU2 */
> @@ -1161,8 +1161,7 @@ struct dvb_frontend* nxt200x_attach(const struct nxt200x_config* config,
>
> /* read card id */
> nxt200x_readbytes(state, 0x00, buf, 5);
> - dprintk("NXT info: %02X %02X %02X %02X %02X\n",
> - buf[0], buf[1], buf[2], buf[3], buf[4]);
> + dprintk("NXT info: %*ph\n", 5, buf);
>
> /* set demod chip */
> switch (buf[0]) {
> @@ -1201,8 +1200,7 @@ struct dvb_frontend* nxt200x_attach(const struct nxt200x_config* config,
>
> error:
> kfree(state);
> - printk("Unknown/Unsupported NXT chip: %02X %02X %02X %02X %02X\n",
> - buf[0], buf[1], buf[2], buf[3], buf[4]);
> + pr_err("Unknown/Unsupported NXT chip: %*ph\n", 5, buf);
> return NULL;
> }
>
> diff --git a/drivers/media/dvb/frontends/rtl2830.c b/drivers/media/dvb/frontends/rtl2830.c
> index 93612eb..8fa8b08 100644
> --- a/drivers/media/dvb/frontends/rtl2830.c
> +++ b/drivers/media/dvb/frontends/rtl2830.c
> @@ -392,7 +392,7 @@ static int rtl2830_get_frontend(struct dvb_frontend *fe)
> if (ret)
> goto err;
>
> - dbg("%s: TPS=%02x %02x %02x", __func__, buf[0], buf[1], buf[2]);
> + dbg("%s: TPS=%*ph", __func__, 3, buf);
>
> switch ((buf[0] >> 2) & 3) {
> case 0:
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-08-07 22:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 16:43 [PATCH 01/11] saa7164: use native print_hex_dump() instead of custom one Andy Shevchenko
2012-08-07 16:43 ` [PATCH 02/11] dvb: nxt200x: apply levels to the printk()s Andy Shevchenko
2012-08-07 16:43 ` [PATCH 03/11] common: tunners: use %*ph to dump small buffers Andy Shevchenko
2012-08-07 16:43 ` [PATCH 04/11] dvb-usb: " Andy Shevchenko
2012-08-07 23:04 ` Antti Palosaari
2012-08-07 16:43 ` [PATCH 05/11] dvb: frontends: " Andy Shevchenko
2012-08-07 22:34 ` Antti Palosaari [this message]
2012-08-07 16:43 ` [PATCH 06/11] radio-shark2: use %*ph to print " Andy Shevchenko
2012-08-07 16:43 ` [PATCH 07/11] gspca: " Andy Shevchenko
2012-08-07 16:43 ` [PATCH 08/11] dvb: use %*ph to hexdump " Andy Shevchenko
2012-08-07 16:43 ` [PATCH 09/11] ati_remote: use %*ph to dump " Andy Shevchenko
2012-08-07 16:43 ` [PATCH 10/11] saa7127: use %*ph to print " Andy Shevchenko
2012-08-07 16:43 ` [PATCH 11/11] au0828: use %*ph to dump " Andy Shevchenko
2012-08-13 19:41 ` Mauro Carvalho Chehab
2012-08-14 3:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502197FB.7090500@iki.fi \
--to=crope@iki.fi \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.