From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
qemu-devel@nongnu.org, john.williams@petalogix.com,
edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces
Date: Wed, 08 Aug 2012 09:55:53 +0200 [thread overview]
Message-ID: <50221B89.50204@redhat.com> (raw)
In-Reply-To: <1344383184.14961.10.camel@PetaLogix-ws2>
Il 08/08/2012 01:46, Peter Crosthwaite ha scritto:
> Hi All,
>
> We seem to be having difficulty getting a review/merge on this patch. I
> have sent two series, two pings and a PULL, with only a single reply
> from P. Maydell asking for other reviewers to weigh in:
>
> --------- on July 17 P. Maydell wrote -----------
>
> I guess I should mention that I'm assuming somebody else is going to
> review
> this patchset. It looks generally OK to me but whether the stream API
> has the details of QOM interface use right is a bit out of my area
> of expertise.
>
> -- PMM
>
> ------------------------------------------------
>
> What needs to happen (and what can I do) to make this series go through?
> Edgar has reviewed P2 this morning and I have already remade the series,
> but my primary concern is this patch, considering it touches the core
> QOM infrastructure.
>
> I have tested this patch on target i386 with no obvious breakages along
> with testing on the the embedded platforms we work with (Zynq and MB).
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
:)
Paolo
next prev parent reply other threads:[~2012-08-08 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 3:07 [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA Peter A. G. Crosthwaite
2012-08-06 3:07 ` [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces Peter A. G. Crosthwaite
2012-08-07 23:46 ` Peter Crosthwaite
2012-08-08 7:55 ` Paolo Bonzini [this message]
2012-08-06 3:07 ` [Qemu-devel] [PATCH 2/2] xilinx_axi*: Re-implemented interconnect Peter A. G. Crosthwaite
2012-08-07 23:03 ` Edgar E. Iglesias
-- strict thread matches above, loose matches on Subject: below --
2012-08-10 2:30 [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA Peter A. G. Crosthwaite
2012-08-10 2:30 ` [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces Peter A. G. Crosthwaite
2012-08-10 3:16 [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA Peter A. G. Crosthwaite
2012-08-10 3:16 ` [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces Peter A. G. Crosthwaite
2012-08-10 9:15 ` Andreas Färber
2012-08-10 10:43 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50221B89.50204@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=john.williams@petalogix.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.